refactor(http): centralize response error handling with helper function

Author: jentyk

mpt_api_client/http/async_client.py

@@ -1,14 +1,15 @@
 import os
 from typing import Any
 
-from httpx import AsyncClient, HTTPError, HTTPStatusError, RequestError
+from httpx import AsyncClient, HTTPError, RequestError
 from httpx_retries import Retry, RetryTransport
 
 from mpt_api_client.constants import APPLICATION_JSON
-from mpt_api_client.exceptions import MPTError, MPTMaxRetryError, transform_http_status_exception
+from mpt_api_client.exceptions import MPTError, MPTMaxRetryError
 from mpt_api_client.http.client import json_to_file_payload
 from mpt_api_client.http.client_utils import get_query_params, validate_base_url
 from mpt_api_client.http.query_options import QueryOptions
+from mpt_api_client.http.request_response_utils import handle_response_http_error
 from mpt_api_client.http.types import HeaderTypes, QueryParam, RequestFiles, Response
 
 
@@ -102,10 +103,8 @@ async def request(  # noqa: WPS211
         except HTTPError as err:
             raise MPTError(f"HTTP Error: {err}") from err
 
-        try:
-            response.raise_for_status()
-        except HTTPStatusError as http_status_exception:
-            raise transform_http_status_exception(http_status_exception) from http_status_exception
+        handle_response_http_error(response)
+
         return Response(
             headers=dict(response.headers),
             status_code=response.status_code,

mpt_api_client/http/client.py

@@ -2,13 +2,14 @@
 import os
 from typing import Any
 
-from httpx import Client, HTTPError, HTTPStatusError, RequestError
+from httpx import Client, HTTPError, RequestError
 from httpx_retries import Retry, RetryTransport
 
 from mpt_api_client.constants import APPLICATION_JSON
-from mpt_api_client.exceptions import MPTError, MPTMaxRetryError, transform_http_status_exception
+from mpt_api_client.exceptions import MPTError, MPTMaxRetryError
 from mpt_api_client.http.client_utils import get_query_params, validate_base_url
 from mpt_api_client.http.query_options import QueryOptions
+from mpt_api_client.http.request_response_utils import handle_response_http_error
 from mpt_api_client.http.types import HeaderTypes, QueryParam, RequestFiles, Response
 from mpt_api_client.models import ResourceData
 
@@ -111,10 +112,8 @@ def request(  # noqa: WPS211
         except HTTPError as err:
             raise MPTError(f"HTTP Error: {err}") from err
 
-        try:
-            response.raise_for_status()
-        except HTTPStatusError as http_status_exception:
-            raise transform_http_status_exception(http_status_exception) from http_status_exception
+        handle_response_http_error(response)
+
         return Response(
             headers=dict(response.headers),
             status_code=response.status_code,

mpt_api_client/http/request_response_utils.py

@@ -0,0 +1,12 @@
+from httpx import HTTPStatusError
+from httpx import Response as HTTPXResponse
+
+from mpt_api_client.exceptions import transform_http_status_exception
+
+
+def handle_response_http_error(response: HTTPXResponse) -> None:
+    """Handles HTTP response error by raising a transformed HTTPStatusError exception."""
+    try:
+        response.raise_for_status()
+    except HTTPStatusError as http_status_exception:
+        raise transform_http_status_exception(http_status_exception) from http_status_exception