Add more JS tests for close instruction

Author: lorisleiva

clients/js/test/close.test.ts

@@ -1,11 +1,17 @@
 import {
   address,
   appendTransactionMessageInstruction,
+  appendTransactionMessageInstructions,
+  generateKeyPairSigner,
   getUtf8Encoder,
   pipe,
 } from '@solana/web3.js';
 import test from 'ava';
-import { fetchMaybeMetadata, getCloseInstruction } from '../src';
+import {
+  fetchMaybeMetadata,
+  getCloseInstruction,
+  getSetAuthorityInstruction,
+} from '../src';
 import {
   createCanonicalBuffer,
   createCanonicalMetadata,
@@ -53,11 +59,95 @@ test('it can close canonical metadata accounts', async (t) => {
   t.false(account.exists);
 });
 
-test.todo('the set authority of a canonical metadata can close the account');
+test('the set authority of a canonical metadata can close the account', async (t) => {
+  // Given the following authority and deployed program.
+  const client = createDefaultSolanaClient();
+  const [authority, explicitAuthority] = await Promise.all([
+    generateKeyPairSignerWithSol(client),
+    generateKeyPairSigner(),
+  ]);
+  const [program, programData] = await createDeployedProgram(client, authority);
+
+  // And the following initialized canonical metadata account.
+  const [metadata] = await createCanonicalMetadata(client, {
+    authority,
+    program,
+    programData,
+    seed: 'dummy',
+    data: getUtf8Encoder().encode('Hello, World!'),
+  });
+
+  // And given an explicit authority is set on the metadata account.
+  const setAuthorityIx = getSetAuthorityInstruction({
+    account: metadata,
+    authority,
+    newAuthority: explicitAuthority.address,
+    program,
+    programData,
+  });
+
+  // When the explicit authority closes the metadata account.
+  const closeIx = getCloseInstruction({
+    account: metadata,
+    authority: explicitAuthority,
+    destination: explicitAuthority.address,
+  });
+  await pipe(
+    await createDefaultTransaction(client, authority),
+    (tx) => appendTransactionMessageInstructions([setAuthorityIx, closeIx], tx),
+    (tx) => signAndSendTransaction(client, tx)
+  );
+
+  // Then we expect the metadata account to no longer exist.
+  const account = await fetchMaybeMetadata(client.rpc, metadata);
+  t.false(account.exists);
+});
+
+test('the current upgrade authority of program can close its canonical metadata account even when an authority is set on the account', async (t) => {
+  // Given the following authority and deployed program.
+  const client = createDefaultSolanaClient();
+  const [authority, explicitAuthority] = await Promise.all([
+    generateKeyPairSignerWithSol(client),
+    generateKeyPairSigner(),
+  ]);
+  const [program, programData] = await createDeployedProgram(client, authority);
+
+  // And the following initialized canonical metadata account.
+  const [metadata] = await createCanonicalMetadata(client, {
+    authority,
+    program,
+    programData,
+    seed: 'dummy',
+    data: getUtf8Encoder().encode('Hello, World!'),
+  });
 
-test.todo(
-  'the current upgrade authority of program can close its canonical metadata account even when an authority is set on the account'
-);
+  // And given an explicit authority is set on the metadata account.
+  const setAuthorityIx = getSetAuthorityInstruction({
+    account: metadata,
+    authority,
+    newAuthority: explicitAuthority.address,
+    program,
+    programData,
+  });
+
+  // When the program authority closes the metadata account.
+  const closeIx = getCloseInstruction({
+    account: metadata,
+    authority,
+    destination: authority.address,
+    program,
+    programData,
+  });
+  await pipe(
+    await createDefaultTransaction(client, authority),
+    (tx) => appendTransactionMessageInstructions([setAuthorityIx, closeIx], tx),
+    (tx) => signAndSendTransaction(client, tx)
+  );
+
+  // Then we expect the metadata account to no longer exist.
+  const account = await fetchMaybeMetadata(client.rpc, metadata);
+  t.false(account.exists);
+});
 
 test('it can close non-canonical metadata accounts', async (t) => {
   // Given the following authority and deployed program.
@@ -125,14 +215,6 @@ test('it can close canonical buffers', async (t) => {
   t.false(account.exists);
 });
 
-test.todo(
-  'the authority that created a canonical buffer can close it even if the upgrade authority of the program changed'
-);
-
-test.todo(
-  'the current upgrade authority of program can close its canonical metadata account even if created by a different previous authority'
-);
-
 test('it can close non-canonical buffers', async (t) => {
   // Given the following authority and deployed program.
   const client = createDefaultSolanaClient();