Skip to content

Code review #1

@Jannepen

Description

@Jannepen

Downloaded zip-file 8.10.2022 at 5pm

I was not able to run the code on my computer due to the JavaFx dependencies, so I settled for just reading the code.
The quality of code seems good and comments made to the code helped a lot in reading the code. Unit testing is also comprehensive enough, testing the important classes.

Couple of suggestions:

-All the classes are currently in the same package. I think dividing UI classes and functionality classes into different packages would make things more clear.

-The method constructNfa is quite long. Would it be possible to divide it into smaller methods?

I found it quite hard to find things to suggest, which I suppose means that the project is in a really good state. Good luck with the rest of the project!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions