Skip to content

Peer review #2

@Saukka

Description

@Saukka

Downloaded the project at 22.00 on October 15.

Running the application works and the tests (9) show no failures or errors.

Due to the project being about regular epressions and nfa, it takes some time to understand the code, but the code is very well commented which helps a lot. The algorithms do their job nicely.

I would divide the UI and application logic classes into different packages, and add a small explanation what each class does at the top of the class.

If I were to suggest an addition, I would include a small guide/a few examples in the UI of simple regex expressions the user can try.

Nice work and good luck with the rest of the project 👍

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions