Skip to content

Fix invalid props being passed to <A>#1420

Merged
LadyBluenotes merged 3 commits into
solidjs:mainfrom
amirhhashemi:fix-button-props
Feb 5, 2026
Merged

Fix invalid props being passed to <A>#1420
LadyBluenotes merged 3 commits into
solidjs:mainfrom
amirhhashemi:fix-button-props

Conversation

@amirhhashemi

Copy link
Copy Markdown
Collaborator

Fixes an issue where <ButtonLink> was forwarding its custom props (variant) to the underlying <A> component.

@bolt-new-by-stackblitz

Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify

netlify Bot commented Feb 5, 2026

Copy link
Copy Markdown

Deploy Preview for solid-docs ready!

Name Link
🔨 Latest commit 99fa0c5
🔍 Latest deploy log https://app.netlify.com/projects/solid-docs/deploys/69850822db990600084673ff
😎 Deploy Preview https://deploy-preview-1420--solid-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@LadyBluenotes LadyBluenotes enabled auto-merge (squash) February 5, 2026 21:13
@LadyBluenotes LadyBluenotes merged commit e34f013 into solidjs:main Feb 5, 2026
3 checks passed
@amirhhashemi amirhhashemi deleted the fix-button-props branch February 6, 2026 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants