Skip to content

Commit f4e593b

Browse files
committed
fix: URL to path conversion in manifest resolver
1 parent 9d5d783 commit f4e593b

3 files changed

Lines changed: 14 additions & 4 deletions

File tree

.changeset/brown-mice-train.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@solidjs/start": patch
3+
---
4+
5+
Fix URL to path conversion in manifest resolver

.vscode/settings.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
// "source.organizeImports": "explicit"
44
},
55
"typescript.tsdk": "node_modules/typescript/lib",
6-
"editor.formatOnSave": true,
6+
"editor.formatOnSave": false,
77
"editor.defaultFormatter": "oxc.oxc-vscode",
88
"[typescript]": {
99
"editor.defaultFormatter": "oxc.oxc-vscode"

packages/start/src/config/manifest.ts

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import fs from "node:fs";
22
import path from "node:path";
33
import { type PluginOption, type ViteDevServer, version as viteVersion } from "vite";
4+
import { fileURLToPath } from "node:url";
45

56
import { findStylesInModuleGraph } from "../server/collect-styles.ts";
67
import { VIRTUAL_MODULES } from "./constants.ts";
@@ -20,12 +21,16 @@ export function manifest(start: SolidStartOptions): PluginOption {
2021
return `\0${VIRTUAL_MODULES.clientViteManifest}`;
2122
if (id === VIRTUAL_MODULES.getClientManifest)
2223
return this.resolve(
23-
new URL("../server/manifest/client-manifest", import.meta.url).pathname,
24+
fileURLToPath(new URL("../server/manifest/client-manifest", import.meta.url)),
2425
);
2526
if (id === VIRTUAL_MODULES.getManifest) {
2627
return this.environment.config.consumer === "client"
27-
? this.resolve(new URL("../server/manifest/client-manifest", import.meta.url).pathname)
28-
: this.resolve(new URL("../server/manifest/ssr-manifest", import.meta.url).pathname);
28+
? this.resolve(
29+
fileURLToPath(new URL("../server/manifest/client-manifest", import.meta.url)),
30+
)
31+
: this.resolve(
32+
fileURLToPath(new URL("../server/manifest/ssr-manifest", import.meta.url)),
33+
);
2934
}
3035
if (id === VIRTUAL_MODULES.middleware) {
3136
if (start.middleware) return await this.resolve(start.middleware);

0 commit comments

Comments
 (0)