Skip to content

Commit 10bccf4

Browse files
fixed logging
1 parent 2a22288 commit 10bccf4

2 files changed

Lines changed: 12 additions & 6 deletions

File tree

src/app.py

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,8 @@ def feed_lobsters():
6060

6161
@scheduler.task('interval', id='scrapeJob', seconds=900, max_instances=1, next_run_time=datetime.now())
6262
def scrape_job():
63-
print('Executing scraping job.')
63+
logger = get_logger()
64+
logger.info('Executing scraping job.')
6465
hn_scraper = HackerNewsScraper()
6566
hn_scraper.scrape()
6667
lobsters_scraper = LobstersScraper()
@@ -83,7 +84,7 @@ def init_logger():
8384
log_formatter = logging.Formatter('[%(asctime)s %(levelname)s] %(message)s', "%Y-%m-%d %H:%M:%S")
8485

8586
file_handler = RotatingFileHandler(log_file_path, mode='a', maxBytes=25 * 1024 * 1024,
86-
backupCount=1, encoding=None, delay=0)
87+
backupCount=1, encoding=None, delay=0)
8788
file_handler.setFormatter(log_formatter)
8889
file_handler.setLevel(logging.INFO)
8990

@@ -97,19 +98,26 @@ def init_logger():
9798
rootLogger.addHandler(file_handler)
9899
rootLogger.addHandler(consoleHandler)
99100

101+
100102
def init_db():
101103
db = SqliteDatabase(Path.home() / "hnd.db")
102104
BaseModel._meta.database.initialize(db)
103105
db.connect()
104106
db.create_tables([Story])
105107

106108

109+
def get_logger():
110+
root_logger = logging.getLogger('root')
111+
return root_logger
112+
113+
107114
if __name__ == '__main__':
108-
print(f"Starting Hackernewsd. Python version: {sys.version}")
109115
init_logger()
110116
init_db()
117+
logger = get_logger()
118+
logger.info(f"Starting Hackernewsd. Python version: {sys.version}")
111119
rc_file = json.loads(read_rc_file())
112120
scheduler.init_app(app)
113121
scheduler.start()
114122
serve(app, host=rc_file["host"], port=rc_file["port"])
115-
# app.run(port=5555)
123+
# app.run(port=5555)

src/scrapers.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,6 @@ def scrape(self):
122122
self.logger.info(f"It took {str(stopwatch)} for a full cycle for Hackernews.")
123123
except Exception as e:
124124
self.logger.error(f"Unhandled exception occurred", exc_info=True)
125-
print(e)
126125

127126

128127
class LobstersScraper():
@@ -217,4 +216,3 @@ def scrape(self):
217216
self.logger.info(f"It took {str(stopwatch)} for a full cycle for Lobsters.")
218217
except Exception as e:
219218
self.logger.error(f"Unhandled exception occurred", exc_info=True)
220-
print(e)

0 commit comments

Comments
 (0)