Merge branch 'main' into fix/private-pr-diff-fetch

Author: brendan-kellam

package.json

@@ -7,7 +7,7 @@
         "build": "cross-env SKIP_ENV_VALIDATION=1 yarn workspaces foreach --all --topological run build",
         "test": "yarn workspaces foreach --all --topological run test",
         "lint": "yarn workspaces foreach --all --topological run lint",
-		"lint:fix": "yarn workspaces foreach --all --topological run lint:fix",
+        "lint:fix": "yarn workspaces foreach --all --topological run lint:fix",
         "dev": "concurrently --kill-others --names \"zoekt,worker,web,schemas\" 'yarn dev:zoekt' 'yarn dev:backend' 'yarn dev:web' 'yarn watch:schemas'",
         "with-env": "cross-env PATH=\"$PWD/bin:$PATH\" dotenv -e .env.development -c --",
         "dev:zoekt": "yarn with-env zoekt-webserver -index .sourcebot/index -rpc",

packages/web/src/app/(app)/search/components/searchResultsPage.tsx

@@ -21,7 +21,6 @@ import { createPathWithQueryParams } from "@/lib/utils";
 import { InfoCircledIcon } from "@radix-ui/react-icons";
 import { useLocalStorage } from "@uidotdev/usehooks";
 import { AlertTriangleIcon, BugIcon, FilterIcon, RefreshCwIcon } from "lucide-react";
-import { Session } from "next-auth";
 import { useRouter } from "next/navigation";
 import { useCallback, useEffect, useMemo, useRef, useState } from "react";
 import { useHotkeys } from "react-hotkeys-hook";

packages/web/src/ee/features/chat/components/chatThread/chatThreadListItem.tsx

@@ -277,7 +277,7 @@ const ChatThreadListItemComponent = forwardRef<HTMLDivElement, ChatThreadListIte
             markdownRenderer.removeEventListener('mouseout', handleMouseOut);
             markdownRenderer.removeEventListener('click', handleClick);
         };
-    }, [answerPart, selectedReference?.id]); // Re-run when answerPart changes to ensure we catch new content
+    }, [answerPart, selectedReference?.id, setHoveredReference, setSelectedReference]); // Re-run when answerPart changes to ensure we catch new content
 
     // When the selected reference changes, highlight all associated reference elements
     // and scroll to the nearest one, if needed.

packages/web/src/ee/features/chat/mcp/components/mcpFavicon.tsx

@@ -12,6 +12,9 @@ export const McpFavicon = ({ faviconUrl, className = "w-4 h-4" }: McpFaviconProp
     const [failed, setFailed] = useState(false);
     if (faviconUrl && !failed) {
         return (
+            // Favicons are served from arbitrary MCP server domains, so they aren't
+            // a good fit for `next/image` optimization.
+            // eslint-disable-next-line @next/next/no-img-element
             <img
                 src={faviconUrl}
                 onError={() => setFailed(true)}

packages/web/src/features/agents/review-agent/nodes/gitlabPushMrReviews.test.ts

@@ -1,7 +1,7 @@
 import { expect, test, vi, describe } from 'vitest';
 import { Gitlab } from '@gitbeaker/rest';
 import { gitlabPushMrReviews } from './gitlabPushMrReviews';
-import { sourcebot_pr_payload, sourcebot_file_diff_review, sourcebot_diff_refs } from '../types';
+import { sourcebot_pr_payload, sourcebot_file_diff_review } from '../types';
 
 type GitlabClient = InstanceType<typeof Gitlab>;