Skip to content

Commit 7833a07

Browse files
committed
Address various review feedback
1 parent c2e7885 commit 7833a07

4 files changed

Lines changed: 4 additions & 13 deletions

File tree

packages/web/src/app/(app)/chat/[id]/components/chatThreadPanel.tsx

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -20,14 +20,6 @@ interface ChatThreadPanelProps {
2020
chatName?: string;
2121
}
2222

23-
const normalizeDisabledMcpServerIds = (value: unknown): string[] => {
24-
if (!Array.isArray(value)) {
25-
return [];
26-
}
27-
28-
return value.filter((id): id is string => typeof id === 'string');
29-
}
30-
3123
export const ChatThreadPanel = ({
3224
languageModels,
3325
repos,
@@ -53,7 +45,7 @@ export const ChatThreadPanel = ({
5345
// Use the last user message to determine what repos, contexts, and MCP state we should select by default.
5446
const lastUserMessage = messages.findLast((message) => message.role === "user");
5547
const defaultSelectedSearchScopes = lastUserMessage?.metadata?.selectedSearchScopes ?? [];
56-
const defaultDisabledMcpServerIds = normalizeDisabledMcpServerIds(lastUserMessage?.metadata?.disabledMcpServerIds);
48+
const defaultDisabledMcpServerIds = lastUserMessage?.metadata?.disabledMcpServerIds ?? [];
5749
const [selectedSearchScopes, setSelectedSearchScopes] = useState<SearchScope[]>(defaultSelectedSearchScopes);
5850
const [disabledMcpServerIds, setDisabledMcpServerIds] = useState<string[]>(defaultDisabledMcpServerIds);
5951

@@ -65,7 +57,7 @@ export const ChatThreadPanel = ({
6557
try {
6658
setInputMessage(chatState.inputMessage);
6759
setSelectedSearchScopes(chatState.selectedSearchScopes);
68-
setDisabledMcpServerIds(normalizeDisabledMcpServerIds(chatState.disabledMcpServerIds));
60+
setDisabledMcpServerIds(chatState.disabledMcpServerIds);
6961
} catch {
7062
console.error('Invalid chat state in session storage');
7163
} finally {

packages/web/src/app/(app)/settings/workspaceAskAgent/workspaceAskAgentPage.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -418,7 +418,7 @@ export function WorkspaceAskAgentPage({ callbackStatus, callbackServer, callback
418418
{/* Connectors section */}
419419
<div className="space-y-6">
420420
<div>
421-
<h4 className="text-sm font-semibold text-foreground">Connectors</h4>
421+
<h4 className="text-md font-semibold text-foreground">Connectors</h4>
422422
<p className="text-sm text-muted-foreground">
423423
Connectors are MCP servers that let Ask Agent use approved external tools alongside your indexed code.
424424
</p>

packages/web/src/features/chat/components/chatThread/chatThreadListItem.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -426,7 +426,7 @@ const ChatThreadListItemComponent = forwardRef<HTMLDivElement, ChatThreadListIte
426426
onHoveredReferenceChanged={setHoveredReference}
427427
style={rightPanelStyle}
428428
/>
429-
) : isNetworkActive ? (
429+
) : (isTurnInProgress) ? (
430430
<div className="space-y-4">
431431
{Array.from({ length: 3 }).map((_, index) => (
432432
<Skeleton key={index} className="w-full h-48" />

packages/web/src/features/chat/components/chatThread/tools/toolSearchToolComponent.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ export const ToolSearchToolComponent = ({ query, results }: ToolSearchToolCompon
2727
<span className="flex-shrink-0">Searched connector tools: <span className="italic">{query}</span></span>
2828
<span className="flex-1" />
2929
<span className="text-xs flex-shrink-0">{results.length} result{results.length === 1 ? '' : 's'}</span>
30-
<Separator orientation="vertical" className="h-3 flex-shrink-0" />
3130
</div>
3231
</CollapsibleTrigger>
3332
<CollapsibleContent>

0 commit comments

Comments
 (0)