fix(worker): stop treating Bitbucket Cloud 410 as removed endpoint

Author: brendan-kellam

packages/backend/src/ee/accountPermissionSyncer.test.ts

@@ -50,7 +50,6 @@ describe('classifyPermissionSyncFailure', () => {
     test.each([
         ['credential_rejected', 'upstream_credential_rejected'],
         ['insufficient_scope', 'upstream_insufficient_scope'],
-        ['permission_endpoint_removed', 'permission_endpoint_removed'],
     ] as const)('fails closed for a classified %s upstream failure', (kind, reason) => {
         expect(classifyPermissionSyncFailure(upstreamError(kind))).toEqual({
             action: 'clear_permissions',

packages/backend/src/ee/accountPermissionSyncer.ts

@@ -35,8 +35,7 @@ type AccountPermissionSyncJob = {
 export type PermissionCleanupReason =
     | 'oauth_invalid_grant'
     | 'upstream_credential_rejected'
-    | 'upstream_insufficient_scope'
-    | 'permission_endpoint_removed';
+    | 'upstream_insufficient_scope';
 
 export type PermissionCleanupDecision =
     | {
@@ -51,7 +50,6 @@ const PERMISSION_CLEANUP_REASON_MESSAGES: Record<PermissionCleanupReason, string
     oauth_invalid_grant: 'OAuth invalid_grant',
     upstream_credential_rejected: 'upstream credential rejection',
     upstream_insufficient_scope: 'insufficient OAuth scope',
-    permission_endpoint_removed: 'permission endpoint removed',
 };
 
 export const classifyPermissionSyncFailure = (error: unknown): PermissionCleanupDecision => {
@@ -71,9 +69,6 @@ export const classifyPermissionSyncFailure = (error: unknown): PermissionCleanup
         if (error.kind === 'insufficient_scope') {
             return { action: 'clear_permissions', reason: 'upstream_insufficient_scope' };
         }
-        if (error.kind === 'permission_endpoint_removed') {
-            return { action: 'clear_permissions', reason: 'permission_endpoint_removed' };
-        }
     }
 
     return { action: 'preserve_permissions' };

packages/backend/src/ee/permissionSyncError.test.ts

@@ -51,23 +51,13 @@ describe('classifyPermissionSyncUpstreamError', () => {
         ).kind).toBe('rate_limited');
     });
 
-    test('classifies Bitbucket Cloud 410 from the repository-list operation as a removed endpoint', () => {
+    test('does not classify Bitbucket Cloud 410 as a removed permission endpoint', () => {
         const cause = Object.assign(new Error('Gone'), { status: 410 });
 
         expect(classifyPermissionSyncUpstreamError(
             cause,
             'bitbucket-cloud',
             'list_accessible_repositories',
-        ).kind).toBe('permission_endpoint_removed');
-    });
-
-    test('does not generalize HTTP 410 from another provider to a removed permission endpoint', () => {
-        const cause = Object.assign(new Error('Gone'), { status: 410 });
-
-        expect(classifyPermissionSyncUpstreamError(
-            cause,
-            'github',
-            'list_accessible_repositories',
         ).kind).toBe('unknown');
     });
 

packages/backend/src/ee/permissionSyncError.ts

@@ -5,7 +5,6 @@ export type PermissionSyncUpstreamErrorKind =
     | 'credential_rejected'
     | 'insufficient_scope'
     | 'rate_limited'
-    | 'permission_endpoint_removed'
     | 'upstream_unavailable'
     | 'forbidden'
     | 'unknown';
@@ -83,17 +82,6 @@ export const classifyPermissionSyncUpstreamError = (
         );
     }
 
-    if (
-        status === 410 &&
-        provider === 'bitbucket-cloud' &&
-        operation === 'list_accessible_repositories'
-    ) {
-        return new PermissionSyncUpstreamError(
-            'The Bitbucket Cloud permission endpoint is no longer available.',
-            { kind: 'permission_endpoint_removed', provider, operation, status, cause: error },
-        );
-    }
-
     if (
         status === 408 ||
         (status !== null && status >= 500 && status < 600) ||