Commit c3bcde2
committed
docs(ee/audit): address CodeRabbit review on #1582
Three CodeRabbit findings on PR #1582, all verified against current code before fixing.
- Add scim.enabled and scim.disabled rows to the action type table. They are written from a ternary at packages/web/src/ee/features/scim/actions.ts:38 (action: enabled ? 'scim.enabled' : 'scim.disabled') with target type 'org'. My initial grep for the action string missed them because the value is built, not a literal. Actor type is 'user', target type is 'org'.
- Use double quotes around the URL and the API-key header in the new 'fetch with time range' curl example so SOURCEBOT_URL and SOURCEBOT_OWNER_API_KEY actually expand at shell execution. The original example on the page has the same issue but is outside this PR's diff and out of scope here.
- Replace the em-dash placeholder in the since/until table cells with 'Not set' to match the rest of the docs' 'no default' convention and remove ambiguity about whether a blank cell means 'unset' or 'no default'.1 parent a1d79b7 commit c3bcde2
1 file changed
Lines changed: 6 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
151 | 151 | | |
152 | 152 | | |
153 | 153 | | |
| 154 | + | |
| 155 | + | |
154 | 156 | | |
155 | 157 | | |
156 | 158 | | |
| |||
163 | 165 | | |
164 | 166 | | |
165 | 167 | | |
166 | | - | |
167 | | - | |
| 168 | + | |
| 169 | + | |
168 | 170 | | |
169 | 171 | | |
170 | 172 | | |
| |||
176 | 178 | | |
177 | 179 | | |
178 | 180 | | |
179 | | - | |
| 181 | + | |
180 | 182 | | |
181 | | - | |
| 183 | + | |
182 | 184 | | |
183 | 185 | | |
184 | 186 | | |
| |||
0 commit comments