From 91d2f6cfdc4f490735312c69526740badef86b56 Mon Sep 17 00:00:00 2001 From: Brendan Kellam Date: Tue, 4 Aug 2026 17:35:37 -0700 Subject: [PATCH 1/3] chore(web): resolve outstanding ESLint warnings Clears the four warnings reported by `yarn lint` so the lint run is clean: - Remove unused `Session` import from searchResultsPage.tsx - Remove unused `sourcebot_diff_refs` import from gitlabPushMrReviews.test.ts - Add the stable `setHoveredReference`/`setSelectedReference` callbacks to the effect dependency array in chatThreadListItem.tsx. Both are `useCallback(..., [])`, so the effect's re-run behavior is unchanged. - Suppress `@next/next/no-img-element` for the MCP favicon, matching the existing convention for remote images elsewhere in the codebase. Also normalizes tab indentation to spaces on the root `lint:fix` script line. Co-Authored-By: Claude Opus 5 (1M context) --- package.json | 2 +- .../web/src/app/(app)/search/components/searchResultsPage.tsx | 1 - .../features/chat/components/chatThread/chatThreadListItem.tsx | 2 +- .../web/src/ee/features/chat/mcp/components/mcpFavicon.tsx | 3 +++ .../agents/review-agent/nodes/gitlabPushMrReviews.test.ts | 2 +- 5 files changed, 6 insertions(+), 4 deletions(-) diff --git a/package.json b/package.json index d94080c5b..1373f3f4e 100644 --- a/package.json +++ b/package.json @@ -7,7 +7,7 @@ "build": "cross-env SKIP_ENV_VALIDATION=1 yarn workspaces foreach --all --topological run build", "test": "yarn workspaces foreach --all --topological run test", "lint": "yarn workspaces foreach --all --topological run lint", - "lint:fix": "yarn workspaces foreach --all --topological run lint:fix", + "lint:fix": "yarn workspaces foreach --all --topological run lint:fix", "dev": "concurrently --kill-others --names \"zoekt,worker,web,schemas\" 'yarn dev:zoekt' 'yarn dev:backend' 'yarn dev:web' 'yarn watch:schemas'", "with-env": "cross-env PATH=\"$PWD/bin:$PATH\" dotenv -e .env.development -c --", "dev:zoekt": "yarn with-env zoekt-webserver -index .sourcebot/index -rpc", diff --git a/packages/web/src/app/(app)/search/components/searchResultsPage.tsx b/packages/web/src/app/(app)/search/components/searchResultsPage.tsx index f16ed7726..dcb5f4aea 100644 --- a/packages/web/src/app/(app)/search/components/searchResultsPage.tsx +++ b/packages/web/src/app/(app)/search/components/searchResultsPage.tsx @@ -21,7 +21,6 @@ import { createPathWithQueryParams } from "@/lib/utils"; import { InfoCircledIcon } from "@radix-ui/react-icons"; import { useLocalStorage } from "@uidotdev/usehooks"; import { AlertTriangleIcon, BugIcon, FilterIcon, RefreshCwIcon } from "lucide-react"; -import { Session } from "next-auth"; import { useRouter } from "next/navigation"; import { useCallback, useEffect, useMemo, useRef, useState } from "react"; import { useHotkeys } from "react-hotkeys-hook"; diff --git a/packages/web/src/ee/features/chat/components/chatThread/chatThreadListItem.tsx b/packages/web/src/ee/features/chat/components/chatThread/chatThreadListItem.tsx index d6388443c..2bbc04516 100644 --- a/packages/web/src/ee/features/chat/components/chatThread/chatThreadListItem.tsx +++ b/packages/web/src/ee/features/chat/components/chatThread/chatThreadListItem.tsx @@ -277,7 +277,7 @@ const ChatThreadListItemComponent = forwardRef setFailed(true)} diff --git a/packages/web/src/features/agents/review-agent/nodes/gitlabPushMrReviews.test.ts b/packages/web/src/features/agents/review-agent/nodes/gitlabPushMrReviews.test.ts index 75092cf66..5d4dcfdb4 100644 --- a/packages/web/src/features/agents/review-agent/nodes/gitlabPushMrReviews.test.ts +++ b/packages/web/src/features/agents/review-agent/nodes/gitlabPushMrReviews.test.ts @@ -1,7 +1,7 @@ import { expect, test, vi, describe } from 'vitest'; import { Gitlab } from '@gitbeaker/rest'; import { gitlabPushMrReviews } from './gitlabPushMrReviews'; -import { sourcebot_pr_payload, sourcebot_file_diff_review, sourcebot_diff_refs } from '../types'; +import { sourcebot_pr_payload, sourcebot_file_diff_review } from '../types'; type GitlabClient = InstanceType; From 2bb21f75349ad3264af85cee15ec7783a69313a7 Mon Sep 17 00:00:00 2001 From: Brendan Kellam Date: Tue, 4 Aug 2026 17:36:21 -0700 Subject: [PATCH 2/3] chore: update CHANGELOG for #1537 Co-Authored-By: Claude Opus 5 (1M context) --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4348570d1..fb04fb578 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,6 +13,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Fixed GitLab topic filters being incorrectly case-sensitive. [#1393](https://github.com/sourcebot-dev/sourcebot/pull/1393) - Fixed a crash when searching with `context:` referencing a search context that does not exist; it now returns a graceful error. [#1362](https://github.com/sourcebot-dev/sourcebot/pull/1362) - Fixed search queries failing to parse when negating a bare term that contains a colon (e.g. `-foo:bar`, `-http://example.com`). [#1301](https://github.com/sourcebot-dev/sourcebot/pull/1301) +- Resolved outstanding ESLint warnings so `yarn lint` reports a clean run. [#1537](https://github.com/sourcebot-dev/sourcebot/pull/1537) ## [5.1.5] - 2026-07-31 From bf401d305fc2ad8904fae0b34bc26887e6c270a3 Mon Sep 17 00:00:00 2001 From: Brendan Kellam Date: Tue, 4 Aug 2026 17:37:21 -0700 Subject: [PATCH 3/3] Update CHANGELOG.md --- CHANGELOG.md | 1 - 1 file changed, 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index fb04fb578..4348570d1 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,7 +13,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Fixed GitLab topic filters being incorrectly case-sensitive. [#1393](https://github.com/sourcebot-dev/sourcebot/pull/1393) - Fixed a crash when searching with `context:` referencing a search context that does not exist; it now returns a graceful error. [#1362](https://github.com/sourcebot-dev/sourcebot/pull/1362) - Fixed search queries failing to parse when negating a bare term that contains a colon (e.g. `-foo:bar`, `-http://example.com`). [#1301](https://github.com/sourcebot-dev/sourcebot/pull/1301) -- Resolved outstanding ESLint warnings so `yarn lint` reports a clean run. [#1537](https://github.com/sourcebot-dev/sourcebot/pull/1537) ## [5.1.5] - 2026-07-31