From ce0b087c2370afb032857d42bbe0d56bc1296fbd Mon Sep 17 00:00:00 2001 From: Mark Prins <1165786+mprins@users.noreply.github.com> Date: Sun, 28 Dec 2025 14:39:33 +0000 Subject: [PATCH 1/3] fix Warning: Array to string conversion in metadata.php fixes #198 --- classes/BasicFormatter.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/classes/BasicFormatter.php b/classes/BasicFormatter.php index 699e3a1..20556f8 100644 --- a/classes/BasicFormatter.php +++ b/classes/BasicFormatter.php @@ -63,9 +63,9 @@ protected function renderImage(Image $image) ]; if ($image->isExternal()) { - $this->renderer->externallink($link, $imgdata); + $this->renderer->externallink($link, ...array_values($imgdata)); } else { - $this->renderer->internalmedia(":$link", $imgdata); // prefix with : to ensure absolute src + $this->renderer->internalmedia(":$link", ...array_values($imgdata)); // prefix with : to ensure absolute src } } From c25d584354e13e3d51f72585f9b8292fa7212e00 Mon Sep 17 00:00:00 2001 From: Mark Prins <1165786+mprins@users.noreply.github.com> Date: Sun, 28 Dec 2025 20:59:46 +0100 Subject: [PATCH 2/3] Update classes/BasicFormatter.php Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- classes/BasicFormatter.php | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/classes/BasicFormatter.php b/classes/BasicFormatter.php index 20556f8..31e1535 100644 --- a/classes/BasicFormatter.php +++ b/classes/BasicFormatter.php @@ -65,7 +65,14 @@ protected function renderImage(Image $image) if ($image->isExternal()) { $this->renderer->externallink($link, ...array_values($imgdata)); } else { - $this->renderer->internalmedia(":$link", ...array_values($imgdata)); // prefix with : to ensure absolute src + $this->renderer->internalmedia( + ":$link", + $imgdata['title'], + $imgdata['align'], + $imgdata['width'], + $imgdata['height'], + $imgdata['cache'] + ); // prefix with : to ensure absolute src } } From 4daa9b41a89feaff3109d339578d70d624fecddf Mon Sep 17 00:00:00 2001 From: Mark Prins <1165786+mprins@users.noreply.github.com> Date: Sun, 28 Dec 2025 20:59:54 +0100 Subject: [PATCH 3/3] Update classes/BasicFormatter.php Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- classes/BasicFormatter.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/classes/BasicFormatter.php b/classes/BasicFormatter.php index 31e1535..d651efa 100644 --- a/classes/BasicFormatter.php +++ b/classes/BasicFormatter.php @@ -63,7 +63,7 @@ protected function renderImage(Image $image) ]; if ($image->isExternal()) { - $this->renderer->externallink($link, ...array_values($imgdata)); + $this->renderer->externallink($link, $imgdata['title']); } else { $this->renderer->internalmedia( ":$link",