Evaluation tests

Author: EmilianoSanchez

src/__tests__/browserSuites/evaluations.spec.js

@@ -362,6 +362,37 @@ export default function (config, fetchMock, assert) {
 
   };
 
+  const evaluationsWithRuleBasedSegments = async (splitio) => {
+    fetchMock.getOnce('https://sdk.split.io/api/memberships/emi%40split.io', { status: 200, body: { ms: { k: [{ n: 'segment_excluded_by_rbs' }] } } });
+    fetchMock.getOnce('https://sdk.split.io/api/memberships/mauro%40split.io', { status: 200, body: { ms: {} } });
+    fetchMock.getOnce('https://sdk.split.io/api/memberships/bilal%40split.io', { status: 200, body: { ms: {} } });
+    fetchMock.getOnce('https://sdk.split.io/api/memberships/other_key', { status: 200, body: { ms: {} } });
+
+    const client1 = splitio.client('emi@split.io');
+    await client1.ready();
+    assert.equal(client1.getTreatment('rbs_test_flag'), 'v2', 'key in excluded segment');
+    assert.equal(client1.getTreatment('rbs_test_flag_negated'), 'v1', 'key in excluded segment');
+    await client1.destroy();
+
+    const client2 = splitio.client('mauro@split.io');
+    await client2.ready();
+    assert.equal(client2.getTreatment('rbs_test_flag'), 'v2', 'excluded key');
+    assert.equal(client2.getTreatment('rbs_test_flag_negated'), 'v1', 'excluded key');
+    await client2.destroy();
+
+    const client3 = splitio.client('bilal@split.io');
+    await client3.ready();
+    assert.equal(client3.getTreatment('rbs_test_flag'), 'v1', 'key satisfies the rbs condition');
+    assert.equal(client3.getTreatment('rbs_test_flag_negated'), 'v2', 'key satisfies the rbs condition');
+    await client3.destroy();
+
+    const client4 = splitio.client('other_key');
+    await client4.ready();
+    assert.equal(client4.getTreatment('rbs_test_flag'), 'v2', 'key not in segment');
+    assert.equal(client4.getTreatment('rbs_test_flag_negated'), 'v1', 'key not in segment');
+    await client4.destroy();
+  };
+
   for (i; i < SDK_INSTANCES_TO_TEST; i++) {
     let splitio = SplitFactory(config);
 
@@ -376,13 +407,16 @@ export default function (config, fetchMock, assert) {
       getTreatmentsTests(client);
       getTreatmentsWithConfigTests(client);
       getTreatmentsWithInMemoryAttributes(client);
-      clientTABucket1.destroy();
-      client.destroy();
-      tested++;
 
-      if (tested === SDK_INSTANCES_TO_TEST) {
-        assert.end();
-      }
+      evaluationsWithRuleBasedSegments(splitio).then(() => {
+        clientTABucket1.destroy();
+        client.destroy();
+        tested++;
+
+        if (tested === SDK_INSTANCES_TO_TEST) {
+          assert.end();
+        }
+      });
     });
   }
 }

src/__tests__/mocks/splitchanges.since.-1.json

@@ -10,7 +10,7 @@
         "trafficTypeName": "user",
         "excluded": {
           "keys": [ "mauro@split.io", "gaston@split.io" ],
-          "segments": [ "segment_test" ]
+          "segments": [ "segment_excluded_by_rbs" ]
         },
         "conditions": [
           {

src/__tests__/nodeSuites/evaluations.spec.js

@@ -164,6 +164,17 @@ export default async function (config, key, assert) {
     assert.equal(client.getTreatment('aaaaaaklmnbv', 'ta_bucket1_test'), 'rollout_treatment');
     // With a higher bucket it's ok to get default treatment
     assert.equal(client.getTreatment('nico_test', 'ta_bucket1_test'), 'default_treatment');
+
+    // Rule-based segments
+    assert.equal(client.getTreatment('emi@split.io', 'rbs_test_flag'), 'v2', 'key in excluded segment');
+    assert.equal(client.getTreatment('mauro@split.io', 'rbs_test_flag'), 'v2', 'excluded key');
+    assert.equal(client.getTreatment('bilal@split.io', 'rbs_test_flag'), 'v1', 'key satisfies the rbs condition');
+    assert.equal(client.getTreatment('other_key', 'rbs_test_flag'), 'v2', 'key not in segment');
+
+    assert.equal(client.getTreatment('emi@split.io', 'rbs_test_flag_negated'), 'v1', 'key in excluded segment');
+    assert.equal(client.getTreatment('mauro@split.io', 'rbs_test_flag_negated'), 'v1', 'excluded key');
+    assert.equal(client.getTreatment('bilal@split.io', 'rbs_test_flag_negated'), 'v2', 'key satisfies the rbs condition');
+    assert.equal(client.getTreatment('other_key', 'rbs_test_flag_negated'), 'v1', 'key not in segment');
   };
 
   const getTreatmentsTests = (client, sdkInstance) => {

src/__tests__/nodeSuites/telemetry.spec.js

@@ -55,7 +55,7 @@ export default async function telemetryNodejsSuite(key, fetchMock, assert) {
     // Validate http and method latencies
     const getLatencyCount = buckets => buckets ? buckets.reduce((accum, entry) => accum + entry, 0) : 0;
     assert.equal(getLatencyCount(data.hL.sp), 2, 'Two latency metrics for splitChanges GET request');
-    assert.equal(getLatencyCount(data.hL.se), 6, 'Six latency metrics for segmentChanges GET request');
+    assert.equal(getLatencyCount(data.hL.se), 8, 'Six latency metrics for segmentChanges GET request');
     assert.equal(getLatencyCount(data.hL.te), 1, 'One latency metric for telemetry config POST request');
     assert.equal(getLatencyCount(data.mL.t), 2, 'Two latency metrics for getTreatment (one not ready usage');
     assert.equal(getLatencyCount(data.mL.ts), 1, 'One latency metric for getTreatments');
@@ -66,7 +66,7 @@ export default async function telemetryNodejsSuite(key, fetchMock, assert) {
 
     // @TODO check if iDe value is correct
     assert.deepEqual(data, {
-      mE: {}, hE: { sp: { 500: 1 } }, tR: 0, aR: 0, iQ: 4, iDe: 1, iDr: 0, spC: 35, seC: 3, skC: 3, eQ: 1, eD: 0, sE: [], t: [], ufs: {}
+      mE: {}, hE: { sp: { 500: 1 } }, tR: 0, aR: 0, iQ: 4, iDe: 1, iDr: 0, spC: 35, seC: 4, skC: 4, eQ: 1, eD: 0, sE: [], t: [], ufs: {}
     }, 'metrics/usage JSON payload should be the expected');
 
     finish.next();
@@ -85,7 +85,7 @@ export default async function telemetryNodejsSuite(key, fetchMock, assert) {
     // @TODO check if iDe value is correct
     assert.deepEqual(data, {
       mL: {}, mE: {}, hE: {}, hL: {}, // errors and latencies were popped
-      tR: 0, aR: 0, iQ: 4, iDe: 1, iDr: 0, spC: 35, seC: 3, skC: 3, eQ: 1, eD: 0, sE: [], t: [], ufs: {}
+      tR: 0, aR: 0, iQ: 4, iDe: 1, iDr: 0, spC: 35, seC: 4, skC: 4, eQ: 1, eD: 0, sE: [], t: [], ufs: {}
     }, '2nd metrics/usage JSON payload should be the expected');
     return 200;
   });

src/__tests__/online/node.spec.js

@@ -41,15 +41,14 @@ const key = 'facundo@split.io';
 
 fetchMock.get(url(settings, '/splitChanges?s=1.3&since=-1&rbSince=-1'), { status: 200, body: splitChangesMock1 });
 fetchMock.get(url(settings, '/splitChanges?s=1.3&since=1457552620999&rbSince=100'), { status: 200, body: splitChangesMock2 });
-fetchMock.get(new RegExp(`${url(settings, '/segmentChanges')}/*`), {
-  status: 200, body: {
-    'name': 'segment',
-    'added': [],
-    'removed': [],
-    'since': 1,
-    'till': 1
-  }
-});
+
+const emptySegmentResponse = { added: [], removed: [], since: 1, till: 1 };
+fetchMock.get(new RegExp(`${url(settings, '/segmentChanges/employees')}*`), { status: 200, body: emptySegmentResponse });
+fetchMock.get(new RegExp(`${url(settings, '/segmentChanges/splitters')}*`), { status: 200, body: emptySegmentResponse });
+fetchMock.get(new RegExp(`${url(settings, '/segmentChanges/developers')}*`), { status: 200, body: emptySegmentResponse });
+fetchMock.get(url(settings, '/segmentChanges/segment_excluded_by_rbs?since=-1'), { status: 200, body: { added: ['emi@split.io'], removed: [], since: -1, till: 1 } });
+fetchMock.get(url(settings, '/segmentChanges/segment_excluded_by_rbs?since=1'), { status: 200, body: { added: [], removed: [], since: 1, till: 1 } });
+
 fetchMock.post(url(settings, '/testImpressions/bulk'), 200);
 fetchMock.post(url(settings, '/testImpressions/count'), 200);
 fetchMock.post(url(settings, '/v1/metrics/config'), 200);