Skip to content

Commit edc7d90

Browse files
feat: Update Telemetry protos
1 parent 93dafd4 commit edc7d90

6 files changed

Lines changed: 24 additions & 17 deletions

File tree

openfeature-provider/src/test/java/com/spotify/confidence/FeatureProviderTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@
1414
import com.spotify.confidence.shaded.flags.resolver.v1.ResolveFlagsResponse;
1515
import com.spotify.confidence.shaded.flags.resolver.v1.ResolvedFlag;
1616
import com.spotify.confidence.shaded.flags.types.v1.FlagSchema;
17-
import com.spotify.telemetry.v1.LibraryTraces;
18-
import com.spotify.telemetry.v1.Monitoring;
17+
import com.spotify.telemetry.v1.Types.LibraryTraces;
18+
import com.spotify.telemetry.v1.Types.Monitoring;
1919
import dev.openfeature.sdk.*;
2020
import io.grpc.ManagedChannel;
2121
import io.grpc.Server;

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -270,7 +270,7 @@
270270
<plugin>
271271
<groupId>com.spotify.fmt</groupId>
272272
<artifactId>fmt-maven-plugin</artifactId>
273-
<version>2.20</version>
273+
<version>2.25</version>
274274
<executions>
275275
<execution>
276276
<phase>validate</phase>

sdk-java/src/main/java/com/spotify/confidence/Telemetry.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
package com.spotify.confidence;
22

33
import com.google.common.annotations.VisibleForTesting;
4-
import com.spotify.telemetry.v1.LibraryTraces;
5-
import com.spotify.telemetry.v1.Monitoring;
6-
import com.spotify.telemetry.v1.Platform;
4+
import com.spotify.telemetry.v1.Types.LibraryTraces;
5+
import com.spotify.telemetry.v1.Types.Monitoring;
6+
import com.spotify.telemetry.v1.Types.Platform;
77
import java.util.concurrent.ConcurrentLinkedQueue;
88

99
public class Telemetry {

sdk-java/src/main/java/com/spotify/confidence/TelemetryClientInterceptor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package com.spotify.confidence;
22

3-
import com.spotify.telemetry.v1.Monitoring;
3+
import com.spotify.telemetry.v1.Types.Monitoring;
44
import io.grpc.*;
55
import java.util.Base64;
66
import javax.annotation.Nullable;

sdk-java/src/main/proto/confidence/telemetry.proto renamed to sdk-java/src/main/proto/confidence/telemetry/v1/types/v1/types.proto

Lines changed: 15 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,17 @@ syntax = "proto3";
22

33
package confidence.telemetry.v1;
44
option java_package = "com.spotify.telemetry.v1";
5-
option java_multiple_files = true;
6-
option java_outer_classname = "TelemetryProto";
5+
6+
import "google/protobuf/descriptor.proto";
7+
8+
message MetricAnnotation {
9+
string name = 1;
10+
string unit = 2;
11+
}
12+
13+
extend google.protobuf.EnumValueOptions {
14+
MetricAnnotation metric = 50641;
15+
}
716

817
enum Platform {
918
PLATFORM_UNSPECIFIED = 0;
@@ -37,17 +46,15 @@ message LibraryTraces {
3746
}
3847

3948
enum Library {
40-
LIBRARY_UNSPECIFIED = 0;
49+
LIBRARY_UNKNOWN = 0;
4150
LIBRARY_CONFIDENCE = 1;
4251
LIBRARY_OPEN_FEATURE = 2;
4352
LIBRARY_REACT = 3;
4453
}
4554

4655
enum TraceId {
47-
TRACE_ID_UNSPECIFIED = 0;
48-
TRACE_ID_RESOLVE_LATENCY = 1;
49-
TRACE_ID_STALE_FLAG = 2;
50-
TRACE_ID_FLAG_TYPE_MISMATCH = 3;
51-
TRACE_ID_WITH_CONTEXT = 4;
56+
TRACE_ID_UNKNOWN = 0;
57+
TRACE_ID_RESOLVE_LATENCY = 1 [(metric) = {name: "resolve_latency", unit: "ms"}];
58+
TRACE_ID_STALE_FLAG = 2 [(metric) = {name: "stale_flag"}];
5259
}
5360
}

sdk-java/src/test/java/com/spotify/confidence/ConfidenceIntegrationTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@
1616
import com.spotify.confidence.shaded.flags.resolver.v1.ResolvedFlag;
1717
import com.spotify.confidence.shaded.flags.types.v1.FlagSchema;
1818
import com.spotify.confidence.telemetry.FakeTelemetryClientInterceptor;
19-
import com.spotify.telemetry.v1.LibraryTraces;
20-
import com.spotify.telemetry.v1.Monitoring;
19+
import com.spotify.telemetry.v1.Types.LibraryTraces;
20+
import com.spotify.telemetry.v1.Types.Monitoring;
2121
import io.grpc.ManagedChannel;
2222
import io.grpc.Metadata;
2323
import io.grpc.Server;

0 commit comments

Comments
 (0)