Merge pull request #113 from elbersb/ruff

Switch to ruff for linting/formatting

Author: elbersb

.github/workflows/confidence.yml

@@ -13,7 +13,15 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        python-version: ['3.9', '3.10', '3.11', '3.12']
+        include:
+          - python-version: '3.9'
+            tox-env: py39-min
+          - python-version: '3.10'
+            tox-env: py310
+          - python-version: '3.11'
+            tox-env: py311
+          - python-version: '3.12'
+            tox-env: py312
 
     steps:
     - uses: actions/checkout@v4
@@ -26,9 +34,7 @@ jobs:
       with:
         enable-cache: true
         cache-dependency-glob: "**/pyproject.toml"
-    - name: Install dependencies
-      run: |
-        uv pip install --system -e ".[dev]"
-        uv pip install --system tox tox-gh-actions
+    - name: Install tox
+      run: uv pip install --system tox tox-uv
     - name: Test with tox
-      run: tox
+      run: tox -e ${{ matrix.tox-env }}

.github/workflows/python-publish.yml

@@ -23,12 +23,12 @@ jobs:
       uses: actions/setup-python@v5
       with:
         python-version: '3.11'
-    - name: Install dependencies
-      run: |
-        python -m pip install --upgrade pip
-        pip install build
+    - name: Install uv
+      uses: astral-sh/setup-uv@v5
+    - name: Install build tools
+      run: uv pip install --system build
     - name: Build package
-      run: python -m build
+      run: uv build
     - name: Publish a Python distribution to PyPI
       uses: pypa/gh-action-pypi-publish@release/v1
       with:

.gitignore

@@ -49,17 +49,6 @@ coverage.xml
 *.mo
 *.pot
 
-# Django stuff:
-*.log
-local_settings.py
-
-# Flask stuff:
-instance/
-.webassets-cache
-
-# Scrapy stuff:
-.scrapy
-
 # Sphinx documentation
 docs/_build/
 
@@ -72,26 +61,20 @@ target/
 # pyenv
 .python-version
 
-# celery beat schedule file
-celerybeat-schedule
-
 # dotenv
 .env
 
 # virtualenv
 venv/
 ENV/
 
-# Spyder project settings
-.spyderproject
-
-# Rope project settings
-.ropeproject
-
 .DS_store
-
 .idea/
 
 # uv
 uv.lock
-.venv/
+.venv/
+
+.mypy_cache/
+.pytest_cache/
+.ruff_cache/

CLAUDE.md

@@ -11,7 +11,7 @@ Spotify Confidence is a Python library for A/B test analysis. It provides conven
 ### Setup
 ```bash
 # Install with development dependencies (including tox-uv)
-uv pip install -e ".[dev]"
+uv pip install -e . --group dev
 ```
 
 ### Testing
@@ -34,17 +34,14 @@ uv run tox
 
 ### Code Quality
 ```bash
-# Format code with black (line length: 119)
-uv run black spotify_confidence tests
+# Run linting
+uv run ruff check
 
-# Check formatting without making changes
-uv run black --check --diff spotify_confidence tests
-
-# Lint with flake8 (max line length: 120)
-uv run flake8 spotify_confidence tests
+# Run formatting
+uv run ruff format
 
 # Run all quality checks (as done in CI)
-uv run black --check --diff spotify_confidence tests && uv run flake8 spotify_confidence tests && uv run pytest
+uv run ruff check && uv run ruff format && uv run pytest
 ```
 
 ### Build
@@ -151,7 +148,4 @@ The project uses `tox-uv` to leverage uv's fast package installation and environ
 
 ## Code Style
 
-- Black formatting with 119 character line length
-- Flake8 linting with max line length 120
-- Ignored flake8 rules: E203, E231, W503
-- Excluded from linting: `.venv`, `.tox`, `dist`, `build`, `scratch.py`, `confidence_dev`
+Uses ruff linting and formatting.

CONTRIBUTING.rst

@@ -71,7 +71,7 @@ Ready to contribute? Here's how to set up `confidence` for local development.
 3. Set up your development environment using uv::
 
     $ uv venv
-    $ uv pip install -e ".[dev]"
+    $ uv pip install -e . --group dev
 
    This creates a virtual environment and installs the package in editable mode with all development dependencies.
 
@@ -89,9 +89,9 @@ Ready to contribute? Here's how to set up `confidence` for local development.
 
 6. When you're done making changes, check that your changes pass all quality checks::
 
-    $ uv run black spotify_confidence tests --line-length 119  # Format code
-    $ uv run flake8 spotify_confidence tests                   # Lint code
-    $ uv run pytest                                            # Run tests
+    $ uv run ruff format       # Format code
+    $ uv run ruff check        # Lint code
+    $ uv run pytest            # Run tests
 
    To test across all supported Python versions (3.9, 3.10, 3.11, 3.12)::
 

HISTORY.rst

@@ -2,6 +2,10 @@
 History
 =======
 
+in development
+--------------
+* Modernize infrastructure (pyproject.toml, uv, ruff, update dependencies)
+
 4.0.0 (2024-11-24)
 ------------------
 * Update mininum requirement for Chartify to avoid cropping bug in `chrome-webdriver`

Makefile

@@ -24,12 +24,11 @@ dependencies = [
     "ipywidgets>=8.0.0",
 ]
 
-[project.optional-dependencies]
+[dependency-groups]
 dev = [
     "build",
     "twine",
-    "black>=23.7.0",
-    "flake8>=6.0.0",
+    "ruff>=0.14.11",
     "tox>=4.0.0",
     "tox-uv>=1.0.0",
     "pytest>=7.0.0",
@@ -47,9 +46,12 @@ where = ["."]
 include = ["spotify_confidence*"]
 namespaces = false
 
-[tool.black]
+[tool.ruff]
 line-length = 119
-target-version = ["py39", "py310", "py311", "py312"]
+extend-exclude = ["examples/"]
+
+[tool.ruff.format]
+quote-style = "double"
 
 [tool.pytest.ini_options]
 addopts = "-v -n auto --cov=spotify_confidence --cov-report=html --cov-report=xml --cov-report=term-missing"

pyproject.toml

@@ -13,17 +13,18 @@
 # limitations under the License.
 
 from importlib.metadata import version as _version
-from .analysis.bayesian.bayesian_models import BetaBinomial
+
 from spotify_confidence.analysis.frequentist.chi_squared import ChiSquared
+from spotify_confidence.analysis.frequentist.experiment import Experiment
+from spotify_confidence.analysis.frequentist.sample_size_calculator import SampleSizeCalculator
 from spotify_confidence.analysis.frequentist.t_test import StudentsTTest
 from spotify_confidence.analysis.frequentist.z_test import ZTest
 from spotify_confidence.analysis.frequentist.z_test_linreg import ZTestLinreg
-from spotify_confidence.analysis.frequentist.experiment import Experiment
-from spotify_confidence.analysis.frequentist.sample_size_calculator import SampleSizeCalculator
-from .samplesize.sample_size_calculator import SampleSize
 
 from . import examples
+from .analysis.bayesian.bayesian_models import BetaBinomial
 from .options import options
+from .samplesize.sample_size_calculator import SampleSize
 
 __version__ = _version("spotify_confidence")
 

spotify_confidence/__init__.py

@@ -13,14 +13,15 @@
 # limitations under the License.
 
 from abc import ABC, abstractmethod
-from typing import Union, Iterable, Tuple, List
+from typing import Iterable, List, Tuple, Union
 
 from pandas import DataFrame
 
 from spotify_confidence.chartgrid import ChartGrid
+
+from ..constants import NIM_TYPE
 from .confidence_computer_abc import ConfidenceComputerABC
 from .confidence_grapher_abc import ConfidenceGrapherABC
-from ..constants import NIM_TYPE
 
 
 class ConfidenceABC(ABC):