Skip to content

Commit 51dca16

Browse files
committed
remove stupid ai comment
1 parent 9b1255d commit 51dca16

1 file changed

Lines changed: 0 additions & 5 deletions

File tree

src/filesystem.rs

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -217,11 +217,6 @@ impl DbFsQueries {
217217
SupportedDatabase::Mssql => "CREATE TABLE sqlpage_files(path NVARCHAR(255) NOT NULL PRIMARY KEY, contents VARBINARY(MAX), last_modified DATETIME2(3) NOT NULL DEFAULT CURRENT_TIMESTAMP);",
218218
SupportedDatabase::Postgres => "CREATE TABLE IF NOT EXISTS sqlpage_files(path VARCHAR(255) NOT NULL PRIMARY KEY, contents BYTEA, last_modified TIMESTAMP DEFAULT CURRENT_TIMESTAMP);",
219219
SupportedDatabase::Snowflake => "CREATE TABLE IF NOT EXISTS sqlpage_files(path VARCHAR(255) NOT NULL PRIMARY KEY, contents VARBINARY, last_modified TIMESTAMP_TZ DEFAULT CONVERT_TIMEZONE('UTC', CURRENT_TIMESTAMP()));",
220-
// Oracle doesn't support IF NOT EXISTS for tables in standard SQL (until 23c). For broader compatibility, we just attempt to create it.
221-
// Also, Oracle uses BLOB for binary data, and TIMESTAMP is fine.
222-
// However, the test script drops the table before creating it, so we can skip IF NOT EXISTS check for test compatibility if needed.
223-
// But for general usage, we might want to be careful. For now, let's keep the generic one but handle the ORA-01843 issue by ensuring date format.
224-
// Actually, ORA-01843 is often due to implicit conversions.
225220
_ => "CREATE TABLE IF NOT EXISTS sqlpage_files(path VARCHAR(255) NOT NULL PRIMARY KEY, contents BLOB, last_modified TIMESTAMP DEFAULT CURRENT_TIMESTAMP);",
226221
}
227222
}

0 commit comments

Comments
 (0)