feat: add support for New Architecture and TurboModule

hebertcisco · hebertcisco · commit 94daa3a2bd31 · 2026-02-10T23:01:03.000-03:00
Implement TurboModule support for CodePush to enable compatibility with
the React Native New Architecture.

- Add TurboModule specification in `src/NativeCodePush.ts`
- Configure `codegenConfig` in `package.json`
- Implement Android bridge for both old and new architectures
- Update `CodePush.js` to prefer `TurboModuleRegistry` over `NativeModules`
diff --git a/CodePush.js b/CodePush.js
@@ -1,11 +1,11 @@
 import { AcquisitionManager as Sdk } from "code-push/script/acquisition-sdk";
 import { Alert } from "./AlertAdapter";
 import requestFetchAdapter from "./request-fetch-adapter";
-import { AppState, Platform } from "react-native";
+import { AppState, Platform, TurboModuleRegistry } from "react-native";
 import log from "./logging";
 import hoistStatics from 'hoist-non-react-statics';
 
-let NativeCodePush = require("react-native").NativeModules.CodePush;
+let NativeCodePush = (TurboModuleRegistry?.get('CodePush')) || require("react-native").NativeModules.CodePush;
 const PackageMixins = require("./package-mixins")(NativeCodePush);
 
 async function checkForUpdate(deploymentKey = null, handleBinaryVersionMismatchCallback = null) {
diff --git a/android/app/build.gradle b/android/app/build.gradle
@@ -40,6 +40,16 @@ android {
     defaultConfig {
         consumerProguardFiles 'proguard-rules.pro'
     }
+
+    sourceSets {
+        main {
+            if (IS_NEW_ARCHITECTURE_ENABLED) {
+                java.srcDirs += ['src/newarch/java']
+            } else {
+                java.srcDirs += ['src/oldarch/java']
+            }
+        }
+    }
 }
 
 dependencies {
diff --git a/android/app/src/main/java/com/microsoft/codepush/react/CodePushNativeModule.java b/android/app/src/main/java/com/microsoft/codepush/react/CodePushNativeModule.java
@@ -46,7 +46,7 @@
 import java.util.UUID;
 
 @OptIn(markerClass = UnstableReactNativeAPI.class)
-public class CodePushNativeModule extends BaseJavaModule {
+public class CodePushNativeModule extends CodePushNativeModuleSpec {
     private String mBinaryContentsHash = null;
     private String mClientUniqueId = null;
     private LifecycleEventListener mLifecycleEventListener = null;
@@ -82,6 +82,11 @@ public CodePushNativeModule(ReactApplicationContext reactContext, CodePush codeP
 
     @Override
     public Map<String, Object> getConstants() {
+        return getTypedExportedConstants();
+    }
+
+    @Override
+    public Map<String, Object> getTypedExportedConstants() {
         final Map<String, Object> constants = new HashMap<>();
 
         constants.put("codePushInstallModeImmediate", CodePushInstallMode.IMMEDIATE.getValue());
@@ -500,8 +505,9 @@ public void getConfiguration(Promise promise) {
         }
     }
 
+    @Override
     @ReactMethod
-    public void getUpdateMetadata(final int updateState, final Promise promise) {
+    public void getUpdateMetadata(final double updateState, final Promise promise) {
         AsyncTask<Void, Void, Void> asyncTask = new AsyncTask<Void, Void, Void>() {
             @Override
             protected Void doInBackground(Void... params) {
@@ -520,11 +526,11 @@ protected Void doInBackground(Void... params) {
                         currentUpdateIsPending = mSettingsManager.isPendingUpdate(currentHash);
                     }
 
-                    if (updateState == CodePushUpdateState.PENDING.getValue() && !currentUpdateIsPending) {
+                    if ((int)updateState == CodePushUpdateState.PENDING.getValue() && !currentUpdateIsPending) {
                         // The caller wanted a pending update
                         // but there isn't currently one.
                         promise.resolve(null);
-                    } else if (updateState == CodePushUpdateState.RUNNING.getValue() && currentUpdateIsPending) {
+                    } else if ((int)updateState == CodePushUpdateState.RUNNING.getValue() && currentUpdateIsPending) {
                         // The caller wants the running update, but the current
                         // one is pending, so we need to grab the previous.
                         JSONObject previousPackage = mUpdateManager.getPreviousPackage();
@@ -625,8 +631,9 @@ protected Void doInBackground(Void... params) {
         asyncTask.executeOnExecutor(AsyncTask.THREAD_POOL_EXECUTOR);
     }
 
+    @Override
     @ReactMethod
-    public void installUpdate(final ReadableMap updatePackage, final int installMode, final int minimumBackgroundDuration, final Promise promise) {
+    public void installUpdate(final ReadableMap updatePackage, final double installMode, final double minimumBackgroundDuration, final Promise promise) {
         AsyncTask<Void, Void, Void> asyncTask = new AsyncTask<Void, Void, Void>() {
             @Override
             protected Void doInBackground(Void... params) {
@@ -640,17 +647,17 @@ protected Void doInBackground(Void... params) {
                         mSettingsManager.savePendingUpdate(pendingHash, /* isLoading */false);
                     }
 
-                    if (installMode == CodePushInstallMode.ON_NEXT_RESUME.getValue() ||
+                    if ((int)installMode == CodePushInstallMode.ON_NEXT_RESUME.getValue() ||
                         // We also add the resume listener if the installMode is IMMEDIATE, because
                         // if the current activity is backgrounded, we want to reload the bundle when
                         // it comes back into the foreground.
-                        installMode == CodePushInstallMode.IMMEDIATE.getValue() ||
-                        installMode == CodePushInstallMode.ON_NEXT_SUSPEND.getValue()) {
+                        (int)installMode == CodePushInstallMode.IMMEDIATE.getValue() ||
+                        (int)installMode == CodePushInstallMode.ON_NEXT_SUSPEND.getValue()) {
 
                         // Store the minimum duration on the native module as an instance
                         // variable instead of relying on a closure below, so that any
                         // subsequent resume-based installs could override it.
-                        CodePushNativeModule.this.mMinimumBackgroundDuration = minimumBackgroundDuration;
+                        CodePushNativeModule.this.mMinimumBackgroundDuration = (int)minimumBackgroundDuration;
 
                         if (mLifecycleEventListener == null) {
                             // Ensure we do not add the listener twice.
@@ -672,7 +679,7 @@ public void onHostResume() {
                                     // the foreground, so explicitly wait for it to be backgrounded first
                                     if (lastPausedDate != null) {
                                         long durationInBackground = (new Date().getTime() - lastPausedDate.getTime()) / 1000;
-                                        if (installMode == CodePushInstallMode.IMMEDIATE.getValue()
+                                        if ((int)installMode == CodePushInstallMode.IMMEDIATE.getValue()
                                                 || durationInBackground >= CodePushNativeModule.this.mMinimumBackgroundDuration) {
                                             CodePushUtils.log("Loading bundle on resume");
                                             restartAppInternal(false);
@@ -686,8 +693,8 @@ public void onHostPause() {
                                     // resumed, we can detect how long it was in the background.
                                     lastPausedDate = new Date();
 
-                                    if (installMode == CodePushInstallMode.ON_NEXT_SUSPEND.getValue() && mSettingsManager.isPendingUpdate(null)) {
-                                        appSuspendHandler.postDelayed(loadBundleRunnable, minimumBackgroundDuration * 1000);
+                                    if ((int)installMode == CodePushInstallMode.ON_NEXT_SUSPEND.getValue() && mSettingsManager.isPendingUpdate(null)) {
+                                        appSuspendHandler.postDelayed(loadBundleRunnable, (int)minimumBackgroundDuration * 1000);
                                     }
                                 }
 
@@ -700,7 +707,11 @@ public void onHostDestroy() {
                         }
                     }
 
-                    promise.resolve("");
+                    if ((int)installMode == CodePushInstallMode.IMMEDIATE.getValue()) {
+                        loadBundle();
+                    }
+
+                    promise.resolve(null);
                 } catch(CodePushUnknownException e) {
                     CodePushUtils.log(e);
                     promise.reject(e);
@@ -822,13 +833,15 @@ public void clearUpdates() {
         mCodePush.clearUpdates();
     }
 
+    @Override
     @ReactMethod
     public void addListener(String eventName) {
         // Set up any upstream listeners or background tasks as necessary
     }
 
+    @Override
     @ReactMethod
-    public void removeListeners(Integer count) {
+    public void removeListeners(double count) {
         // Remove upstream listeners, stop unnecessary background tasks
     }
 
diff --git a/android/app/src/newarch/java/com/microsoft/codepush/react/CodePushNativeModuleSpec.java b/android/app/src/newarch/java/com/microsoft/codepush/react/CodePushNativeModuleSpec.java
@@ -0,0 +1,9 @@
+package com.microsoft.codepush.react;
+
+import com.facebook.react.bridge.ReactApplicationContext;
+
+public abstract class CodePushNativeModuleSpec extends NativeRNCodePushSpec {
+    public CodePushNativeModuleSpec(ReactApplicationContext reactContext) {
+        super(reactContext);
+    }
+}
diff --git a/android/app/src/oldarch/java/com/microsoft/codepush/react/CodePushNativeModuleSpec.java b/android/app/src/oldarch/java/com/microsoft/codepush/react/CodePushNativeModuleSpec.java
@@ -0,0 +1,34 @@
+package com.microsoft.codepush.react;
+
+import com.facebook.react.bridge.ReactApplicationContext;
+import com.facebook.react.bridge.ReactContextBaseJavaModule;
+import com.facebook.react.bridge.Promise;
+import com.facebook.react.bridge.ReadableMap;
+
+public abstract class CodePushNativeModuleSpec extends ReactContextBaseJavaModule {
+    public CodePushNativeModuleSpec(ReactApplicationContext reactContext) {
+        super(reactContext);
+    }
+
+    public abstract void allow(Promise promise);
+    public abstract void clearPendingRestart(Promise promise);
+    public abstract void disallow(Promise promise);
+    public abstract void restartApp(boolean onlyIfUpdateIsPending, Promise promise);
+    public abstract void downloadUpdate(ReadableMap updatePackage, boolean notifyProgress, Promise promise);
+    public abstract void getConfiguration(Promise promise);
+    public abstract void getUpdateMetadata(double updateState, Promise promise);
+    public abstract void getNewStatusReport(Promise promise);
+    public abstract void installUpdate(ReadableMap updatePackage, double installMode, double minimumBackgroundDuration, Promise promise);
+    public abstract void isFailedUpdate(String packageHash, Promise promise);
+    public abstract void isFirstRun(String packageHash, Promise promise);
+    public abstract void notifyApplicationReady(Promise promise);
+    public abstract void recordStatusReported(ReadableMap statusReport);
+    public abstract void saveStatusReportForRetry(ReadableMap statusReport);
+    public abstract void downloadAndReplaceCurrentBundle(String remoteBundleUrl);
+    public abstract void clearUpdates();
+    public abstract void getLatestRollbackInfo(Promise promise);
+    public abstract void setLatestRollbackInfo(String packageHash, Promise promise);
+    public abstract void addListener(String eventName);
+    public abstract void removeListeners(double count);
+    public abstract java.util.Map<String, Object> getTypedExportedConstants();
+}
diff --git a/package.json b/package.json
@@ -81,5 +81,13 @@
       "postlink": "node node_modules/@srcpush/react-native-code-push/scripts/postlink/run",
       "postunlink": "node node_modules/@srcpush/react-native-code-push/scripts/postunlink/run"
     }
+  },
+  "codegenConfig": {
+    "name": "RNCodePush",
+    "type": "modules",
+    "jsSrcsDir": "src",
+    "android": {
+      "javaPackageName": "com.microsoft.codepush.react"
+    }
   }
 }
diff --git a/src/NativeCodePush.ts b/src/NativeCodePush.ts
@@ -0,0 +1,39 @@
+import type { TurboModule } from 'react-native';
+import { TurboModuleRegistry } from 'react-native';
+
+export interface Spec extends TurboModule {
+  getConstants(): {
+    codePushInstallModeImmediate: number;
+    codePushInstallModeOnNextRestart: number;
+    codePushInstallModeOnNextResume: number;
+    codePushInstallModeOnNextSuspend: number;
+    codePushUpdateStateRunning: number;
+    codePushUpdateStatePending: number;
+    codePushUpdateStateLatest: number;
+  };
+
+  allow(): Promise<void>;
+  clearPendingRestart(): Promise<void>;
+  disallow(): Promise<void>;
+  restartApp(onlyIfUpdateIsPending: boolean): Promise<void>;
+  downloadUpdate(updatePackage: Object, notifyProgress: boolean): Promise<Object>;
+  getConfiguration(): Promise<Object>;
+  getUpdateMetadata(updateState: number): Promise<Object>;
+  getNewStatusReport(): Promise<Object>;
+  installUpdate(updatePackage: Object, installMode: number, minimumBackgroundDuration: number): Promise<void>;
+  isFailedUpdate(packageHash: string): Promise<boolean>;
+  isFirstRun(packageHash: string): Promise<boolean>;
+  notifyApplicationReady(): Promise<void>;
+  recordStatusReported(statusReport: Object): void;
+  saveStatusReportForRetry(statusReport: Object): void;
+  downloadAndReplaceCurrentBundle(remoteBundleUrl: string): void;
+  clearUpdates(): void;
+  getLatestRollbackInfo(): Promise<Object>;
+  setLatestRollbackInfo(packageHash: string): Promise<void>;
+  
+  // Events
+  addListener(eventName: string): void;
+  removeListeners(count: number): void;
+}
+
+export default TurboModuleRegistry.get<Spec>('CodePush');

Original file line number	Diff line number	Diff line change
`@@ -81,5 +81,13 @@`
`81`	`81`	`"postlink": "node node_modules/@srcpush/react-native-code-push/scripts/postlink/run",`
`82`	`82`	`"postunlink": "node node_modules/@srcpush/react-native-code-push/scripts/postunlink/run"`
`83`	`83`	`}`
	`84`	`+ },`
	`85`	`+ "codegenConfig": {`
	`86`	`+ "name": "RNCodePush",`
	`87`	`+ "type": "modules",`
	`88`	`+ "jsSrcsDir": "src",`
	`89`	`+ "android": {`
	`90`	`+ "javaPackageName": "com.microsoft.codepush.react"`
	`91`	`+ }`
`84`	`92`	`}`
`85`	`93`	`}`