fix: adjust TXT record formatting to preserve quotes for improved consistency

Author: ondbeh

internal/stackitprovider/helper.go

@@ -141,10 +141,10 @@ func safeTTLToInt32(ttl endpoint.TTL) *int32 {
 
 // formatTXTContent splits long TXT records into 255-character chunks separated by spaces.
 func formatTXTContent(content string) string {
-	cleanContent := strings.Trim(content, "\"")
+	cleanContent := strings.Trim(content, `"`)
 
 	if len(cleanContent) <= 255 {
-		return `"` + cleanContent + `"`
+		return content
 	}
 
 	var chunks []string
@@ -161,11 +161,9 @@ func formatTXTContent(content string) string {
 
 // unformatTXTContent reverses the DNS chunking and quoting process.
 func unformatTXTContent(content string) string {
-	if !strings.HasPrefix(content, "\"") || !strings.HasSuffix(content, "\"") {
-		return content
+	if strings.Contains(content, `" "`) {
+		return strings.ReplaceAll(content, `" "`, ``)
 	}
 
-	trimmed := content[1 : len(content)-1]
-
-	return strings.ReplaceAll(trimmed, `" "`, "")
+	return content
 }

internal/stackitprovider/helper_test.go

@@ -232,16 +232,21 @@ func TestFormatTXTContent(t *testing.T) {
 		{
 			name:    "Short string without quotes",
 			content: "hello world",
-			want:    `"hello world"`,
+			want:    "hello world",
 		},
 		{
 			name:    "Short string with existing quotes",
 			content: `"hello world"`,
 			want:    `"hello world"`,
 		},
 		{
-			name:    "Exactly 255 characters",
+			name:    "Exactly 255 characters unquoted",
 			content: string255,
+			want:    string255,
+		},
+		{
+			name:    "Exactly 255 characters quoted",
+			content: `"` + string255 + `"`,
 			want:    `"` + string255 + `"`,
 		},
 		{
@@ -283,17 +288,17 @@ func TestUnformatTXTContent(t *testing.T) {
 		{
 			name:    "Single chunk quoted string",
 			content: `"hello world"`,
-			want:    "hello world",
+			want:    `"hello world"`,
 		},
 		{
 			name:    "Two chunk string",
 			content: `"hello" "world"`,
-			want:    "helloworld",
+			want:    `"helloworld"`,
 		},
 		{
 			name:    "Three chunk string",
 			content: `"chunk1" "chunk2" "chunk3"`,
-			want:    "chunk1chunk2chunk3",
+			want:    `"chunk1chunk2chunk3"`,
 		},
 	}