fix(typescript): Fix all 'any' types and non-null assertions (STA-34)

- Replace all 'any' types with proper typed interfaces
- Add UserRow and SessionRow interfaces for database results
- Add TaskRow interface for task database queries
- Replace 'any' with 'unknown' for flexible data types
- Fix non-null assertions with proper validation
- Improve type safety across CLI, models, and services
- All tests passing with zero lint warnings

Author: jonathanpeterwu

scripts/test-redis-storage.ts

@@ -456,7 +456,7 @@ async function main() {
     ORDER BY created_at DESC LIMIT 3
   `
     )
-    .all() as any[];
+    .all() as Array<{ trace_id: string; tier: string }>;
 
   for (const trace of recentTraces) {
     const tierIcon =

src/cli/index.ts

@@ -138,15 +138,20 @@ program
         WHERE project_id = ?
       `
         )
-        .get(session.projectId) as any;
+        .get(session.projectId) as {
+        total_frames: number;
+        active_frames: number;
+        closed_frames: number;
+        total_sessions: number;
+      };
 
       const contextCount = db
         .prepare(
           `
         SELECT COUNT(*) as count FROM contexts
       `
         )
-        .get() as any;
+        .get() as { count: number };
 
       const eventCount = db
         .prepare(
@@ -156,7 +161,7 @@ program
         WHERE f.project_id = ?
       `
         )
-        .get(session.projectId) as any;
+        .get(session.projectId) as { count: number };
 
       console.log('📊 StackMemory Status:');
       console.log(
@@ -187,11 +192,16 @@ program
         LIMIT 3
       `
         )
-        .all(session.projectId) as any[];
+        .all(session.projectId) as Array<{
+        name: string;
+        type: string;
+        state: string;
+        created: string;
+      }>;
 
       if (recentFrames.length > 0) {
         console.log(`\n   Recent Activity:`);
-        recentFrames.forEach((f: any) => {
+        recentFrames.forEach((f) => {
           const stateIcon = f.state === 'active' ? '🟢' : '⚫';
           console.log(`     ${stateIcon} ${f.name} [${f.type}] - ${f.created}`);
         });

src/core/types.ts

@@ -1,15 +1,15 @@
 export interface PersistenceAdapter {
   connect(): Promise<void>;
   disconnect(): Promise<void>;
-  execute(query: string, params?: any[]): Promise<QueryResult>;
+  execute(query: string, params?: unknown[]): Promise<QueryResult>;
   beginTransaction(): Promise<void>;
   commit(): Promise<void>;
   rollback(): Promise<void>;
   isConnected(): boolean;
 }
 
 export interface QueryResult {
-  rows: any[];
+  rows: unknown[];
   rowCount: number;
   fields?: Array<{
     name: string;
@@ -22,8 +22,8 @@ export interface TraceData {
   sessionId: string;
   timestamp: Date;
   type: string;
-  data: any;
-  metadata?: Record<string, any>;
+  data: unknown;
+  metadata?: Record<string, unknown>;
 }
 
 export interface ContextData {
@@ -33,5 +33,5 @@ export interface ContextData {
   content: string;
   timestamp: Date;
   type: string;
-  metadata?: Record<string, any>;
+  metadata?: Record<string, unknown>;
 }

src/mcp/stackmemory-mcp-server.ts

@@ -61,7 +61,7 @@ interface ExecuteTaskArgs {
 interface AgentTurnArgs {
   sessionId: string;
   action: string;
-  context?: Record<string, any>;
+  context?: Record<string, unknown>;
 }
 
 interface TaskStatusArgs {

src/models/user.model.ts

@@ -5,6 +5,31 @@ import { logger } from '../core/monitoring/logger.js';
 
 type Database = BetterSqlite3.Database;
 
+interface UserRow {
+  id: string;
+  sub: string;
+  email: string;
+  name?: string;
+  avatar?: string;
+  tier: 'free' | 'pro' | 'enterprise';
+  permissions: string;
+  organizations: string;
+  api_keys: string;
+  created_at: number;
+  updated_at: number;
+  last_login_at?: number;
+  metadata?: string;
+}
+
+interface SessionRow {
+  id: string;
+  user_id: string;
+  token: string;
+  expires_at: number;
+  created_at: number;
+  metadata?: string;
+}
+
 export interface User {
   id: string;
   sub: string; // Subject identifier from auth provider
@@ -22,7 +47,7 @@ export interface User {
   createdAt: Date;
   updatedAt: Date;
   lastLoginAt?: Date;
-  metadata?: Record<string, any>;
+  metadata?: Record<string, unknown>;
 }
 
 export interface UserSession {
@@ -31,7 +56,7 @@ export interface UserSession {
   token: string;
   expiresAt: Date;
   createdAt: Date;
-  metadata?: Record<string, any>;
+  metadata?: Record<string, unknown>;
 }
 
 export class UserModel {
@@ -105,10 +130,14 @@ export class UserModel {
   }
 
   async createUser(userData: Partial<User>): Promise<User> {
+    if (!userData.sub || !userData.email) {
+      throw new Error('User sub and email are required');
+    }
+
     const user: User = {
       id: userData.id || uuidv4(),
-      sub: userData.sub!,
-      email: userData.email!,
+      sub: userData.sub,
+      email: userData.email,
       name: userData.name,
       avatar: userData.avatar,
       tier: userData.tier || 'free',
@@ -148,7 +177,7 @@ export class UserModel {
 
   async findUserBySub(sub: string): Promise<User | null> {
     const stmt = this.db.prepare('SELECT * FROM users WHERE sub = ?');
-    const row = stmt.get(sub) as any;
+    const row = stmt.get(sub) as UserRow | undefined;
 
     if (!row) {
       return null;
@@ -159,7 +188,7 @@ export class UserModel {
 
   async findUserByEmail(email: string): Promise<User | null> {
     const stmt = this.db.prepare('SELECT * FROM users WHERE email = ?');
-    const row = stmt.get(email) as any;
+    const row = stmt.get(email) as UserRow | undefined;
 
     if (!row) {
       return null;
@@ -170,7 +199,7 @@ export class UserModel {
 
   async findUserById(id: string): Promise<User | null> {
     const stmt = this.db.prepare('SELECT * FROM users WHERE id = ?');
-    const row = stmt.get(id) as any;
+    const row = stmt.get(id) as UserRow | undefined;
 
     if (!row) {
       return null;
@@ -267,7 +296,7 @@ export class UserModel {
 
   async findSessionByToken(token: string): Promise<UserSession | null> {
     const stmt = this.db.prepare('SELECT * FROM user_sessions WHERE token = ?');
-    const row = stmt.get(token) as any;
+    const row = stmt.get(token) as SessionRow | undefined;
 
     if (!row) {
       return null;
@@ -350,7 +379,7 @@ export class UserModel {
       WHERE (ak.expires_at IS NULL OR ak.expires_at > datetime('now'))
     `);
 
-    const rows = stmt.all() as any[];
+    const rows = stmt.all() as SessionRow[];
 
     for (const row of rows) {
       if (await bcrypt.compare(apiKey, row.key_hash)) {
@@ -393,7 +422,7 @@ export class UserModel {
       ORDER BY created_at DESC
     `);
 
-    const rows = stmt.all(userId) as any[];
+    const rows = stmt.all(userId) as SessionRow[];
     return rows.map((row) => ({
       id: row.id,
       name: row.name,
@@ -403,7 +432,7 @@ export class UserModel {
   }
 
   // Helper methods
-  private rowToUser(row: any): User {
+  private rowToUser(row: UserRow): User {
     return {
       id: row.id,
       sub: row.sub,
@@ -421,7 +450,7 @@ export class UserModel {
     };
   }
 
-  private rowToSession(row: any): UserSession {
+  private rowToSession(row: SessionRow): UserSession {
     return {
       id: row.id,
       userId: row.user_id,

src/services/context-service.ts

@@ -6,6 +6,21 @@ import Database from 'better-sqlite3';
 import { join } from 'path';
 import { existsSync } from 'fs';
 
+interface TaskRow {
+  id: string;
+  title: string;
+  description?: string;
+  status?: string;
+  priority?: string;
+  tags?: string;
+  external_id?: string;
+  external_identifier?: string;
+  external_url?: string;
+  metadata?: string;
+  created_at: number;
+  updated_at: number;
+}
+
 export class ContextService {
   private logger: Logger;
   private db: Database.Database | null = null;
@@ -55,7 +70,7 @@ export class ContextService {
 
       // Load all tasks from database
       const stmt = this.db.prepare('SELECT * FROM tasks');
-      const rows = stmt.all() as any[];
+      const rows = stmt.all() as TaskRow[];
 
       for (const row of rows) {
         const task: Task = {