diff --git a/drivers/fsi/fsi-core.c b/drivers/fsi/fsi-core.c index c6c115993ebc13..8a2a02df52acf5 100644 --- a/drivers/fsi/fsi-core.c +++ b/drivers/fsi/fsi-core.c @@ -674,8 +674,7 @@ static ssize_t cfam_read(struct file *filep, char __user *buf, size_t count, for (total_len = 0; total_len < count; total_len += read_len) { __be32 data; - read_len = min_t(size_t, count, 4); - read_len -= off & 0x3; + read_len = min_t(size_t, 4 - (off & 0x3), count - total_len); rc = fsi_slave_read(slave, off, &data, read_len); if (rc) @@ -711,8 +710,7 @@ static ssize_t cfam_write(struct file *filep, const char __user *buf, for (total_len = 0; total_len < count; total_len += write_len) { __be32 data; - write_len = min_t(size_t, count, 4); - write_len -= off & 0x3; + write_len = min_t(size_t, 4 - (off & 0x3), count - total_len); rc = copy_from_user(&data, buf + total_len, write_len); if (rc) { diff --git a/drivers/fsi/fsi-master-ast-cf.c b/drivers/fsi/fsi-master-ast-cf.c index e67d7cd30fcaa4..d9f6f84a72ed7a 100644 --- a/drivers/fsi/fsi-master-ast-cf.c +++ b/drivers/fsi/fsi-master-ast-cf.c @@ -184,7 +184,7 @@ static bool check_relative_address(struct fsi_master_acf *master, int id, /* We know that the addresses are limited to 21 bits, so this won't * overflow the signed rel_addr */ - rel_addr = addr - last_addr; + rel_addr = (int32_t)addr - (int32_t)last_addr; if (rel_addr > 255 || rel_addr < -256) return false;