From 99b11f368708ebad79e1e84c70bd13fdb6af88f1 Mon Sep 17 00:00:00 2001 From: Claude Date: Wed, 12 Aug 2026 06:33:04 +0000 Subject: [PATCH] test: migrate `stats/base/dists/erlang/mode` to ULP-based assertions Migrate the tests for `stats/base/dists/erlang/mode` from relative tolerance testing to ULP difference testing using `@stdlib/assert/is-almost-same-value`, per the tracking issue. The ULP bound is 1 for both `test/test.js` and `test/test.native.js`, which is the measured minimum over the full 200-value fixture set for both the JavaScript and the C implementations. Ref: https://github.com/stdlib-js/stdlib/issues/11352 Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_01X5p9mkf3BDoxrUSw8e5ZfV --- .../stats/base/dists/erlang/mode/test/test.js | 13 ++----------- .../base/dists/erlang/mode/test/test.native.js | 13 ++----------- 2 files changed, 4 insertions(+), 22 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/erlang/mode/test/test.js b/lib/node_modules/@stdlib/stats/base/dists/erlang/mode/test/test.js index 983cb2a889d5..816adc25e441 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/erlang/mode/test/test.js +++ b/lib/node_modules/@stdlib/stats/base/dists/erlang/mode/test/test.js @@ -21,11 +21,10 @@ // MODULES // var tape = require( 'tape' ); -var abs = require( '@stdlib/math/base/special/abs' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var mode = require( './../lib' ); @@ -106,8 +105,6 @@ tape( 'if provided `lambda <= 0`, the function returns `NaN`', function test( t tape( 'the function returns the mode of an Erlang distribution', function test( t ) { var expected; var lambda; - var delta; - var tol; var k; var i; var y; @@ -117,13 +114,7 @@ tape( 'the function returns the mode of an Erlang distribution', function test( lambda = data.lambda; for ( i = 0; i < expected.length; i++ ) { y = mode( k[i], lambda[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'k: '+k[i]+', lambda: '+lambda[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. k: '+k[i]+'. lambda: '+lambda[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 1 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/erlang/mode/test/test.native.js b/lib/node_modules/@stdlib/stats/base/dists/erlang/mode/test/test.native.js index 387663c57b52..81daf1f0c039 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/erlang/mode/test/test.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/erlang/mode/test/test.native.js @@ -22,12 +22,11 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var tryRequire = require( '@stdlib/utils/try-require' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); // FIXTURES // @@ -109,8 +108,6 @@ tape( 'if provided `lambda <= 0`, the function returns `NaN`', opts, function te tape( 'the function returns the mode of an Erlang distribution', opts, function test( t ) { var expected; var lambda; - var delta; - var tol; var k; var i; var y; @@ -120,13 +117,7 @@ tape( 'the function returns the mode of an Erlang distribution', opts, function lambda = data.lambda; for ( i = 0; i < expected.length; i++ ) { y = mode( k[i], lambda[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'k: '+k[i]+', lambda: '+lambda[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. k: '+k[i]+'. lambda: '+lambda[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 1 ), true, 'returns expected value' ); } t.end(); });