From 4e8ac789b08410c15cd915c0c9373ca7a53c9299 Mon Sep 17 00:00:00 2001 From: Claude Date: Wed, 12 Aug 2026 14:24:12 +0000 Subject: [PATCH] test: migrate `stats/base/dists/gamma/pdf` to ULP-based assertions Replace relative EPS-based tolerance checks with ULP-based assertions using `@stdlib/assert/is-almost-same-value`. ULP bounds were tightened to the measured minimum over the full fixture sets. Ref: https://github.com/stdlib-js/stdlib/issues/11352 Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_01TGwbG5ir9JJQ9XefVFP4rT --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- .../base/dists/gamma/pdf/test/test.factory.js | 33 +++---------------- .../base/dists/gamma/pdf/test/test.native.js | 33 +++---------------- .../base/dists/gamma/pdf/test/test.pdf.js | 33 +++---------------- 3 files changed, 12 insertions(+), 87 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/gamma/pdf/test/test.factory.js b/lib/node_modules/@stdlib/stats/base/dists/gamma/pdf/test/test.factory.js index 1aca1791ba0f..e4dac4b49f5d 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/gamma/pdf/test/test.factory.js +++ b/lib/node_modules/@stdlib/stats/base/dists/gamma/pdf/test/test.factory.js @@ -21,11 +21,10 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var factory = require( './../lib/factory.js' ); @@ -199,10 +198,8 @@ tape( 'if `alpha` equals `0`, the created function evaluates a degenerate distri tape( 'the created function evaluates the pdf for `x` given large `alpha` and `beta`', function test( t ) { var expected; var alpha; - var delta; var beta; var pdf; - var tol; var x; var y; var i; @@ -214,13 +211,7 @@ tape( 'the created function evaluates the pdf for `x` given large `alpha` and `b for ( i = 0; i < x.length; i++ ) { pdf = factory( alpha[i], beta[i] ); y = pdf( x[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', alpha: '+alpha[i]+', beta: '+beta[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 170.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. alpha: '+alpha[i]+'. beta: '+beta[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 275 ), true, 'returns expected value' ); } t.end(); }); @@ -228,10 +219,8 @@ tape( 'the created function evaluates the pdf for `x` given large `alpha` and `b tape( 'the created function evaluates the pdf for `x` given a large shape parameter `alpha`', function test( t ) { var expected; var alpha; - var delta; var beta; var pdf; - var tol; var x; var y; var i; @@ -243,13 +232,7 @@ tape( 'the created function evaluates the pdf for `x` given a large shape parame for ( i = 0; i < x.length; i++ ) { pdf = factory( alpha[i], beta[i] ); y = pdf( x[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', alpha: '+alpha[i]+', beta: '+beta[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 140.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. alpha: '+alpha[i]+'. beta: '+beta[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 168 ), true, 'returns expected value' ); } t.end(); }); @@ -257,10 +240,8 @@ tape( 'the created function evaluates the pdf for `x` given a large shape parame tape( 'the created function evaluates the pdf for `x` given a large rate parameter `beta`', function test( t ) { var expected; var alpha; - var delta; var beta; var pdf; - var tol; var x; var y; var i; @@ -272,13 +253,7 @@ tape( 'the created function evaluates the pdf for `x` given a large rate paramet for ( i = 0; i < x.length; i++ ) { pdf = factory( alpha[i], beta[i] ); y = pdf( x[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', alpha: '+alpha[i]+', beta: '+beta[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 120.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. alpha: '+alpha[i]+'. beta: '+beta[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 208 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/gamma/pdf/test/test.native.js b/lib/node_modules/@stdlib/stats/base/dists/gamma/pdf/test/test.native.js index 20d5fec7d58e..050a398fb6eb 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/gamma/pdf/test/test.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/gamma/pdf/test/test.native.js @@ -22,11 +22,10 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var tryRequire = require( '@stdlib/utils/try-require' ); @@ -153,9 +152,7 @@ tape( 'if `alpha` equals `0`, the function evaluates a degenerate distribution c tape( 'the function evaluates the pdf for `x` given large `alpha` and `beta`', opts, function test( t ) { var expected; var alpha; - var delta; var beta; - var tol; var i; var x; var y; @@ -166,13 +163,7 @@ tape( 'the function evaluates the pdf for `x` given large `alpha` and `beta`', o beta = bothLarge.beta; for ( i = 0; i < x.length; i++ ) { y = pdf( x[i], alpha[i], beta[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', alpha: '+alpha[i]+', beta: '+beta[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 170.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. alpha: '+alpha[i]+'. beta: '+beta[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 275 ), true, 'returns expected value' ); } t.end(); }); @@ -180,9 +171,7 @@ tape( 'the function evaluates the pdf for `x` given large `alpha` and `beta`', o tape( 'the function evaluates the pdf for `x` given large shape parameter `alpha`', opts, function test( t ) { var expected; var alpha; - var delta; var beta; - var tol; var i; var x; var y; @@ -193,13 +182,7 @@ tape( 'the function evaluates the pdf for `x` given large shape parameter `alpha beta = largeShape.beta; for ( i = 0; i < x.length; i++ ) { y = pdf( x[i], alpha[i], beta[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', alpha: '+alpha[i]+', beta: '+beta[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 140.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. alpha: '+alpha[i]+'. beta: '+beta[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 168 ), true, 'returns expected value' ); } t.end(); }); @@ -207,9 +190,7 @@ tape( 'the function evaluates the pdf for `x` given large shape parameter `alpha tape( 'the function evaluates the pdf for `x` given large rate parameter `beta`', opts, function test( t ) { var expected; var alpha; - var delta; var beta; - var tol; var i; var x; var y; @@ -220,13 +201,7 @@ tape( 'the function evaluates the pdf for `x` given large rate parameter `beta`' beta = largeRate.beta; for ( i = 0; i < x.length; i++ ) { y = pdf( x[i], alpha[i], beta[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', alpha: '+alpha[i]+', beta: '+beta[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 120.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. alpha: '+alpha[i]+'. beta: '+beta[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 208 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/gamma/pdf/test/test.pdf.js b/lib/node_modules/@stdlib/stats/base/dists/gamma/pdf/test/test.pdf.js index 6a0c78e903d5..05279de081e6 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/gamma/pdf/test/test.pdf.js +++ b/lib/node_modules/@stdlib/stats/base/dists/gamma/pdf/test/test.pdf.js @@ -21,11 +21,10 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var pdf = require( './../lib' ); @@ -144,9 +143,7 @@ tape( 'if `alpha` equals `0`, the function evaluates a degenerate distribution c tape( 'the function evaluates the pdf for `x` given large `alpha` and `beta`', function test( t ) { var expected; var alpha; - var delta; var beta; - var tol; var i; var x; var y; @@ -157,13 +154,7 @@ tape( 'the function evaluates the pdf for `x` given large `alpha` and `beta`', f beta = bothLarge.beta; for ( i = 0; i < x.length; i++ ) { y = pdf( x[i], alpha[i], beta[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', alpha: '+alpha[i]+', beta: '+beta[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 170.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. alpha: '+alpha[i]+'. beta: '+beta[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 275 ), true, 'returns expected value' ); } t.end(); }); @@ -171,9 +162,7 @@ tape( 'the function evaluates the pdf for `x` given large `alpha` and `beta`', f tape( 'the function evaluates the pdf for `x` given large shape parameter `alpha`', function test( t ) { var expected; var alpha; - var delta; var beta; - var tol; var i; var x; var y; @@ -184,13 +173,7 @@ tape( 'the function evaluates the pdf for `x` given large shape parameter `alpha beta = largeShape.beta; for ( i = 0; i < x.length; i++ ) { y = pdf( x[i], alpha[i], beta[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', alpha: '+alpha[i]+', beta: '+beta[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 140.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. alpha: '+alpha[i]+'. beta: '+beta[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 168 ), true, 'returns expected value' ); } t.end(); }); @@ -198,9 +181,7 @@ tape( 'the function evaluates the pdf for `x` given large shape parameter `alpha tape( 'the function evaluates the pdf for `x` given large rate parameter `beta`', function test( t ) { var expected; var alpha; - var delta; var beta; - var tol; var i; var x; var y; @@ -211,13 +192,7 @@ tape( 'the function evaluates the pdf for `x` given large rate parameter `beta`' beta = largeRate.beta; for ( i = 0; i < x.length; i++ ) { y = pdf( x[i], alpha[i], beta[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', alpha: '+alpha[i]+', beta: '+beta[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 120.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. alpha: '+alpha[i]+'. beta: '+beta[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 208 ), true, 'returns expected value' ); } t.end(); });