From 3349e4ac0b3f005f7bbff006d73ac916a611a343 Mon Sep 17 00:00:00 2001 From: Claude Date: Fri, 14 Aug 2026 09:28:22 +0000 Subject: [PATCH] test: migrate `stats/base/dists/f/stdev` to ULP-based assertions Replaces the relative-tolerance comparison (delta/tol against EPS) in test.js and test.native.js with `isAlmostSameValue`, tightened to the minimum required ULP bound of 2. Ref: https://github.com/stdlib-js/stdlib/issues/11352 --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- .../@stdlib/stats/base/dists/f/stdev/test/test.js | 13 ++----------- .../stats/base/dists/f/stdev/test/test.native.js | 13 ++----------- 2 files changed, 4 insertions(+), 22 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/f/stdev/test/test.js b/lib/node_modules/@stdlib/stats/base/dists/f/stdev/test/test.js index a473e489e2c9..6b8770b427bc 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/f/stdev/test/test.js +++ b/lib/node_modules/@stdlib/stats/base/dists/f/stdev/test/test.js @@ -21,11 +21,10 @@ // MODULES // var tape = require( 'tape' ); -var abs = require( '@stdlib/math/base/special/abs' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var stdev = require( './../lib' ); @@ -108,8 +107,6 @@ tape( 'if provided `d2 <= 4`, the function returns `NaN`', function test( t ) { tape( 'the function returns the standard deviation of an F distribution', function test( t ) { var expected; - var delta; - var tol; var d1; var d2; var i; @@ -120,13 +117,7 @@ tape( 'the function returns the standard deviation of an F distribution', functi d2 = data.d2; for ( i = 0; i < expected.length; i++ ) { y = stdev( d1[i], d2[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'd1: '+d1[i]+', d2: '+d2[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 2.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. d1: '+d1[i]+'. d2: '+d2[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 2 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/f/stdev/test/test.native.js b/lib/node_modules/@stdlib/stats/base/dists/f/stdev/test/test.native.js index 714f33c45621..af831f5a307c 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/f/stdev/test/test.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/f/stdev/test/test.native.js @@ -22,12 +22,11 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var tryRequire = require( '@stdlib/utils/try-require' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); // FIXTURES // @@ -117,8 +116,6 @@ tape( 'if provided `d2 <= 4`, the function returns `NaN`', opts, function test( tape( 'the function returns the standard deviation of an F distribution', opts, function test( t ) { var expected; - var delta; - var tol; var d1; var d2; var i; @@ -129,13 +126,7 @@ tape( 'the function returns the standard deviation of an F distribution', opts, d2 = data.d2; for ( i = 0; i < expected.length; i++ ) { y = stdev( d1[i], d2[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'd1: '+d1[i]+', d2: '+d2[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 2.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. d1: '+d1[i]+'. d2: '+d2[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 2 ), true, 'returns expected value' ); } t.end(); });