From 97d33b9bee0e16b5cfdc44387636845924465abc Mon Sep 17 00:00:00 2001
From: lgraziano <leandro.graziano@epfl.ch>
Date: Mon, 7 Jun 2021 15:49:26 +0200
Subject: [PATCH] fix persistence issue

---
 .../todolist/database/FileStorageDatabase.java         |  2 +-
 .../todolist/database/TodoListRepository.java          | 10 +++-------
 2 files changed, 4 insertions(+), 8 deletions(-)

diff --git a/app/src/main/java/com/github/steroidteam/todolist/database/FileStorageDatabase.java b/app/src/main/java/com/github/steroidteam/todolist/database/FileStorageDatabase.java
index 9aa1dea7..4973d59a 100644
--- a/app/src/main/java/com/github/steroidteam/todolist/database/FileStorageDatabase.java
+++ b/app/src/main/java/com/github/steroidteam/todolist/database/FileStorageDatabase.java
@@ -434,7 +434,7 @@ public CompletableFuture<UUID> putTagInList(UUID todoListID, UUID tagId) {
                 .thenApply(JSONSerializer::serializeTodoList)
                 .thenApply(
                         serializedTodoList -> serializedTodoList.getBytes(StandardCharsets.UTF_8))
-                .thenCompose(bytes -> this.storageService.upload(bytes, listPath))
+                .thenCompose(bytes -> storageService.upload(bytes, listPath))
                 .thenApply(str -> tagId);
     }
 
diff --git a/app/src/main/java/com/github/steroidteam/todolist/database/TodoListRepository.java b/app/src/main/java/com/github/steroidteam/todolist/database/TodoListRepository.java
index 022ad823..45f47807 100644
--- a/app/src/main/java/com/github/steroidteam/todolist/database/TodoListRepository.java
+++ b/app/src/main/java/com/github/steroidteam/todolist/database/TodoListRepository.java
@@ -227,11 +227,6 @@ public LiveData<List<Tag>> getGlobalTags() {
         return globalTags;
     }
 
-    public LiveData<List<Tag>> getUnlinkedTags(UUID todoListID) {
-        setTagsLists(todoListID);
-        return unlinkedTags;
-    }
-
     public void putTagInTodolist(UUID todoListID, UUID tagId) {
         localDatabase
                 .putTagInList(todoListID, tagId)
@@ -243,9 +238,10 @@ public void putTagInTodolist(UUID todoListID, UUID tagId) {
                 .thenAccept(
                         str -> {
                             List<Tag> unlinked = globalTags.getValue();
-                            unlinked.removeAll(globalTags.getValue());
+                            unlinked.removeAll(localTags.getValue());
                             unlinkedTags.postValue(unlinked);
                         });
+        remoteDatabase.putTagInList(todoListID, tagId);
     }
 
     public void putTag(Tag tag) {
@@ -274,7 +270,7 @@ public void removeTagFromTodolist(UUID todoListID, UUID tagId) {
                 .thenAccept(
                         str -> {
                             List<Tag> unlinked = globalTags.getValue();
-                            unlinked.removeAll(globalTags.getValue());
+                            unlinked.removeAll(localTags.getValue());
                             unlinkedTags.postValue(unlinked);
                         });
     }