From 0cd640757fc3acd0493b244801211e17e9191c20 Mon Sep 17 00:00:00 2001 From: Liam Mitchell Date: Mon, 20 Apr 2026 17:35:17 +0200 Subject: [PATCH 1/3] Fix disconnect on windows --- lib/win/src/ble_manager.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/win/src/ble_manager.cc b/lib/win/src/ble_manager.cc index 19d09915..bacb67b0 100644 --- a/lib/win/src/ble_manager.cc +++ b/lib/win/src/ble_manager.cc @@ -413,7 +413,7 @@ void BLEManager::OnConnectionStatusChanged(BluetoothLEDevice device, return; } PeripheralWinrt& peripheral = mDeviceMap[uuid]; - if(peripheral.device.has_value() && &(peripheral.device.value()) == &device ) + if (peripheral.device.has_value() && peripheral.device.value() == device) { peripheral.Disconnect(); mNotifyMap.Remove(uuid); From 5449bf0ff4596876494824bbd3cce1623a70d29c Mon Sep 17 00:00:00 2001 From: Liam Mitchell Date: Mon, 20 Apr 2026 17:36:14 +0200 Subject: [PATCH 2/3] Make it easier to use script for testing --- examples/peripheral-explorer-async.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/examples/peripheral-explorer-async.js b/examples/peripheral-explorer-async.js index 7a6631a1..f4f9a2cb 100644 --- a/examples/peripheral-explorer-async.js +++ b/examples/peripheral-explorer-async.js @@ -79,6 +79,8 @@ noble.on('discover', async (peripheral) => { console.log(); await explore(peripheral); + } else { + console.log(`Peripheral with ID ${peripheral.id} and name ${peripheral.advertisement?.localName} ignored`); } }); From d6bf7a69322668e3a328b3d845ced642b67358c9 Mon Sep 17 00:00:00 2001 From: Liam Mitchell Date: Mon, 20 Apr 2026 17:38:41 +0200 Subject: [PATCH 3/3] Fix win build warnings --- lib/win/src/ble_manager.cc | 2 +- lib/win/src/noble_winrt.cc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/win/src/ble_manager.cc b/lib/win/src/ble_manager.cc index bacb67b0..dc01c375 100644 --- a/lib/win/src/ble_manager.cc +++ b/lib/win/src/ble_manager.cc @@ -290,7 +290,7 @@ bool BLEManager::Connect(const std::string& uuid) // Add to device map mDeviceMap.emplace(std::make_pair(uuid, std::move(peripheral))); - } catch (const std::exception& e) { + } catch (const std::exception&) { mEmit.Connected(uuid, "invalid device address format"); return false; } diff --git a/lib/win/src/noble_winrt.cc b/lib/win/src/noble_winrt.cc index 245df7a4..8aa23308 100644 --- a/lib/win/src/noble_winrt.cc +++ b/lib/win/src/noble_winrt.cc @@ -277,7 +277,7 @@ Napi::Value NobleWinrt::AddressToId(const Napi::CallbackInfo& info) } return Napi::String::New(info.Env(), cleanUuid.c_str()); - } catch (const std::exception& e) { + } catch (const std::exception&) { return info.Env().Null(); } }