From 9c8667b4069643a58591bbf54864581ecaffcb53 Mon Sep 17 00:00:00 2001
From: "Konrad H. Stopsack" <35557324+stopsack@users.noreply.github.com>
Date: Wed, 8 Oct 2025 20:37:26 +0200
Subject: [PATCH 1/3] do not discuss install source b/c now also on CRAN

---
 vignettes/table1.Rmd | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/vignettes/table1.Rmd b/vignettes/table1.Rmd
index 9ac6543..2dadc36 100644
--- a/vignettes/table1.Rmd
+++ b/vignettes/table1.Rmd
@@ -16,7 +16,7 @@ knitr::opts_chunk$set(
 
 # Loading the package
 
-After installation (using `remotes::install_github("stopsack/rifttable")`), load the package with:
+After installation, load the package with:
 
 ```{r setup}
 library(rifttable)

From 529f615388c18fc8207419b5577b95a97efce0d9 Mon Sep 17 00:00:00 2001
From: Davis Vaughan <davis@posit.co>
Date: Wed, 14 Jan 2026 16:13:30 -0500
Subject: [PATCH 2/3] Forcibly retain `label` attribute

---
 tests/testthat/test-missing_data.R  | 14 ++++++++++++--
 tests/testthat/test-table1_design.R | 14 ++++++++++++--
 2 files changed, 24 insertions(+), 4 deletions(-)

diff --git a/tests/testthat/test-missing_data.R b/tests/testthat/test-missing_data.R
index 066243f..990af15 100644
--- a/tests/testthat/test-missing_data.R
+++ b/tests/testthat/test-missing_data.R
@@ -2,9 +2,19 @@ data("breastcancer", package = "risks")
 df <- breastcancer |>
   dplyr::mutate(
     continuous = 1:dplyr::n(),
-    receptor = dplyr::if_else(dplyr::row_number() %in% 9:11, NA, receptor),
+    receptor = {
+      label <- attr(receptor, "label")
+      receptor <- dplyr::if_else(dplyr::row_number() %in% 9:11, NA, receptor)
+      attr(receptor, "label") <- label
+      receptor
+    },
     stage = dplyr::if_else(dplyr::row_number() %in% 29:31, NA, stage),
-    death = dplyr::if_else(dplyr::row_number() %in% 99:101, NA, death),
+    death = {
+      label <- attr(death, "label")
+      dplyr::if_else(dplyr::row_number() %in% 99:101, NA, death)
+      attr(death, "label") <- label
+      death
+    },
     allempty = NA_real_,
     allempty_lgl = allempty == 1
   )
diff --git a/tests/testthat/test-table1_design.R b/tests/testthat/test-table1_design.R
index c3308cc..186513b 100644
--- a/tests/testthat/test-table1_design.R
+++ b/tests/testthat/test-table1_design.R
@@ -2,8 +2,18 @@ data("breastcancer", package = "risks")
 df <- breastcancer |>
   dplyr::mutate(
     continuous = 1:dplyr::n(),
-    receptor = dplyr::if_else(dplyr::row_number() %in% 9:11, NA, receptor),
-    death = dplyr::if_else(dplyr::row_number() %in% 99:101, NA, death),
+    receptor = {
+      label <- attr(receptor, "label")
+      receptor <- dplyr::if_else(dplyr::row_number() %in% 9:11, NA, receptor)
+      attr(receptor, "label") <- label
+      receptor
+    },
+    death = {
+      label <- attr(death, "label")
+      dplyr::if_else(dplyr::row_number() %in% 99:101, NA, death)
+      attr(death, "label") <- label
+      death
+    },
     allempty = NA_integer_,
     allempty_lgl = allempty == 1
   )

From 166e38c94e68c133ecefc7863c2895b07bd76c56 Mon Sep 17 00:00:00 2001
From: Davis Vaughan <davis@posit.co>
Date: Wed, 14 Jan 2026 16:37:09 -0500
Subject: [PATCH 3/3] Actually assign back to `death`

---
 tests/testthat/test-missing_data.R  | 2 +-
 tests/testthat/test-table1_design.R | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/testthat/test-missing_data.R b/tests/testthat/test-missing_data.R
index 990af15..9e34190 100644
--- a/tests/testthat/test-missing_data.R
+++ b/tests/testthat/test-missing_data.R
@@ -11,7 +11,7 @@ df <- breastcancer |>
     stage = dplyr::if_else(dplyr::row_number() %in% 29:31, NA, stage),
     death = {
       label <- attr(death, "label")
-      dplyr::if_else(dplyr::row_number() %in% 99:101, NA, death)
+      death <- dplyr::if_else(dplyr::row_number() %in% 99:101, NA, death)
       attr(death, "label") <- label
       death
     },
diff --git a/tests/testthat/test-table1_design.R b/tests/testthat/test-table1_design.R
index 186513b..68f6ff1 100644
--- a/tests/testthat/test-table1_design.R
+++ b/tests/testthat/test-table1_design.R
@@ -10,7 +10,7 @@ df <- breastcancer |>
     },
     death = {
       label <- attr(death, "label")
-      dplyr::if_else(dplyr::row_number() %in% 99:101, NA, death)
+      death <- dplyr::if_else(dplyr::row_number() %in% 99:101, NA, death)
       attr(death, "label") <- label
       death
     },