scrub string values, lint, cleanup

Author: Yostra

apps/dashboard/e2e/global-setup.ts

@@ -11,7 +11,7 @@ export default async function globalSetup(_config: FullConfig) {
 
   const resolver = createConnectorResolver({
     sources: { stripe: sourceStripe },
-    destinations: { postgres: destinationPostgres, 'google_sheets': destinationGoogleSheets },
+    destinations: { postgres: destinationPostgres, google_sheets: destinationGoogleSheets },
   })
 
   const app = createApp(resolver)

apps/engine/src/__tests__/stripe-to-postgres.test.ts

@@ -187,8 +187,9 @@ describe('engine read → write', () => {
 
     for (const r of records) {
       expect(r.stream).toBe(targetStream)
-      expect((r as any).data).toBeDefined()
-      expect((r as any).data.id).toBeDefined()
+      const data = (r as Record<string, unknown>).data as Record<string, unknown>
+      expect(data).toBeDefined()
+      expect(data.id).toBeDefined()
     }
   })
 

apps/engine/src/api/app.test.ts

@@ -2,6 +2,10 @@ import { beforeEach, describe, expect, it, vi } from 'vitest'
 import type { ConnectorResolver, Message, SourceStateMessage } from '../lib/index.js'
 import { sourceTest, destinationTest, collectFirst } from '../lib/index.js'
 import { createApp } from './app.js'
+import { z } from 'zod'
+
+// eslint-disable-next-line @typescript-eslint/no-explicit-any
+type Json = Record<string, any>
 
 // ---------------------------------------------------------------------------
 // Helpers
@@ -33,7 +37,7 @@ beforeAll(async () => {
           'test',
           {
             connector: sourceTest,
-            configSchema: {} as any,
+            configSchema: z.object({}),
             rawConfigJsonSchema: srcConfigSchema,
           },
         ],
@@ -44,7 +48,7 @@ beforeAll(async () => {
           'test',
           {
             connector: destinationTest,
-            configSchema: {} as any,
+            configSchema: z.object({}),
             rawConfigJsonSchema: destConfigSchema,
           },
         ],
@@ -131,7 +135,7 @@ describe('GET /openapi.json', () => {
   it('has typed connector schemas in components (auto-generated from Zod)', async () => {
     const app = await createApp(resolver)
     const res = await app.request('/openapi.json')
-    const spec = (await res.json()) as any
+    const spec = (await res.json()) as Json
     const schemaNames = Object.keys(spec.components?.schemas ?? {})
 
     expect(schemaNames).toContain('SourceTestConfig')
@@ -150,7 +154,7 @@ describe('GET /openapi.json', () => {
   it('defines NDJSON message schemas with discriminated unions', async () => {
     const app = await createApp(resolver)
     const res = await app.request('/openapi.json')
-    const spec = (await res.json()) as any
+    const spec = (await res.json()) as Json
     const schemas = spec.components.schemas
 
     // Individual message types — zod-openapi uses const for z.literal() in OpenAPI 3.1
@@ -187,18 +191,18 @@ describe('GET /openapi.json', () => {
   it('ControlMessage source_config/destination_config reference typed connector schemas', async () => {
     const app = await createApp(resolver)
     const res = await app.request('/openapi.json')
-    const spec = (await res.json()) as any
+    const spec = (await res.json()) as Json
     const control = spec.components.schemas.ControlMessage.properties.control
 
     const sourceVariant = control.oneOf.find(
-      (v: any) => v.properties?.control_type?.const === 'source_config'
+      (v: Json) => v.properties?.control_type?.const === 'source_config'
     )
     expect(sourceVariant.properties.source_config.$ref).toBe(
       '#/components/schemas/SourceTestConfig'
     )
 
     const destVariant = control.oneOf.find(
-      (v: any) => v.properties?.control_type?.const === 'destination_config'
+      (v: Json) => v.properties?.control_type?.const === 'destination_config'
     )
     expect(destVariant.properties.destination_config.$ref).toBe(
       '#/components/schemas/DestinationTestConfig'
@@ -208,7 +212,7 @@ describe('GET /openapi.json', () => {
   it('/setup spec documents 200 response (not 204)', async () => {
     const app = await createApp(resolver)
     const res = await app.request('/openapi.json')
-    const spec = (await res.json()) as any
+    const spec = (await res.json()) as Json
     const setupOp = spec.paths['/pipeline_setup']?.post
     expect(setupOp).toBeDefined()
     expect(setupOp.responses['200']).toBeDefined()
@@ -218,7 +222,7 @@ describe('GET /openapi.json', () => {
   it('/write spec documents a required NDJSON request body', async () => {
     const app = await createApp(resolver)
     const res = await app.request('/openapi.json')
-    const spec = (await res.json()) as any
+    const spec = (await res.json()) as Json
     const writeOp = spec.paths['/pipeline_write']?.post
     expect(writeOp).toBeDefined()
     const body = writeOp.requestBody
@@ -232,7 +236,7 @@ describe('GET /openapi.json', () => {
   it('/read and /sync spec documents an optional NDJSON request body', async () => {
     const app = await createApp(resolver)
     const res = await app.request('/openapi.json')
-    const spec = (await res.json()) as any
+    const spec = (await res.json()) as Json
 
     for (const path of ['/pipeline_read', '/pipeline_sync'] as const) {
       const op = spec.paths[path]?.post
@@ -247,13 +251,13 @@ describe('GET /openapi.json', () => {
   it('documents the X-Pipeline header on sync routes', async () => {
     const app = await createApp(resolver)
     const res = await app.request('/openapi.json')
-    const spec = (await res.json()) as any
+    const spec = (await res.json()) as Json
 
     // /check is a POST with X-Pipeline header
     const checkOp = spec.paths['/pipeline_check']?.post
     expect(checkOp).toBeDefined()
     const headerParam = checkOp.parameters?.find(
-      (p: any) => p.in === 'header' && p.name === 'x-pipeline'
+      (p: Json) => p.in === 'header' && p.name === 'x-pipeline'
     )
     expect(headerParam).toBeDefined()
   })
@@ -264,9 +268,9 @@ describe('GET /meta/sources', () => {
     const app = await createApp(resolver)
     const res = await app.request('/meta/sources')
     expect(res.status).toBe(200)
-    const body = (await res.json()) as any
+    const body = (await res.json()) as Json
     expect(Array.isArray(body.items)).toBe(true)
-    expect(body.items.find((c: any) => c.type === 'test')?.config_schema).toBeDefined()
+    expect(body.items.find((c: Json) => c.type === 'test')?.config_schema).toBeDefined()
   })
 })
 
@@ -275,7 +279,7 @@ describe('GET /meta/sources/:type', () => {
     const app = await createApp(resolver)
     const res = await app.request('/meta/sources/test')
     expect(res.status).toBe(200)
-    const body = (await res.json()) as any
+    const body = (await res.json()) as Json
     expect(body.config_schema).toBeDefined()
   })
 
@@ -291,9 +295,9 @@ describe('GET /meta/destinations', () => {
     const app = await createApp(resolver)
     const res = await app.request('/meta/destinations')
     expect(res.status).toBe(200)
-    const body = (await res.json()) as any
+    const body = (await res.json()) as Json
     expect(Array.isArray(body.items)).toBe(true)
-    expect(body.items.find((c: any) => c.type === 'test')?.config_schema).toBeDefined()
+    expect(body.items.find((c: Json) => c.type === 'test')?.config_schema).toBeDefined()
   })
 })
 
@@ -302,7 +306,7 @@ describe('GET /meta/destinations/:type', () => {
     const app = await createApp(resolver)
     const res = await app.request('/meta/destinations/test')
     expect(res.status).toBe(200)
-    const body = (await res.json()) as any
+    const body = (await res.json()) as Json
     expect(body.config_schema).toBeDefined()
   })
 
@@ -372,7 +376,7 @@ describe('POST /check', () => {
     const events = await readNdjson<Record<string, unknown>>(res)
     const statuses = events.filter((e) => e.type === 'connection_status')
     expect(statuses).toHaveLength(2)
-    expect(statuses.every((s: any) => s.connection_status.status === 'succeeded')).toBe(true)
+    expect(statuses.every((s: Json) => s.connection_status.status === 'succeeded')).toBe(true)
   })
 })
 
@@ -436,7 +440,7 @@ describe('POST /read', () => {
               'test',
               {
                 connector: sourceTest,
-                configSchema: {} as any,
+                configSchema: z.object({}),
                 rawConfigJsonSchema: srcConfigSchema,
                 rawInputJsonSchema: inputSchema,
               },
@@ -448,7 +452,7 @@ describe('POST /read', () => {
               'test',
               {
                 connector: destinationTest,
-                configSchema: {} as any,
+                configSchema: z.object({}),
                 rawConfigJsonSchema: destConfigSchema,
               },
             ],
@@ -459,7 +463,7 @@ describe('POST /read', () => {
 
     it('spec uses SourceInputMessage schema for /read and /sync request body when source has input schema', async () => {
       const res = await inputApp.request('/openapi.json')
-      const spec = (await res.json()) as any
+      const spec = (await res.json()) as Json
 
       for (const path of ['/pipeline_read', '/pipeline_sync'] as const) {
         const body = spec.paths[path]?.post?.requestBody
@@ -794,8 +798,8 @@ describe('POST /source_discover', () => {
     const events = await readNdjson<Record<string, unknown>>(res)
     const catalogs = events.filter((e) => e.type === 'catalog')
     expect(catalogs).toHaveLength(1)
-    const catalog = (catalogs[0] as any).catalog
-    const streamNames = catalog.streams.map((s: any) => s.name)
+    const catalog = (catalogs[0] as Json).catalog
+    const streamNames = catalog.streams.map((s: Json) => s.name)
     expect(streamNames).toContain('customers')
     expect(streamNames).toContain('products')
   })
@@ -824,7 +828,7 @@ describe('POST /source_discover', () => {
     const events = await readNdjson<Record<string, unknown>>(res)
     const traces = events.filter((e) => e.type === 'trace')
     expect(traces).toHaveLength(1)
-    const trace = (traces[0] as any).trace
+    const trace = (traces[0] as Json).trace
     expect(trace.trace_type).toBe('error')
     expect(trace.error.failure_type).toBe('system_error')
     expect(trace.error.message).toContain('network unreachable')

apps/engine/src/api/index.ts

@@ -13,7 +13,7 @@ const port = Number(process.env.PORT || 3001)
 async function main() {
   const resolver = await createConnectorResolver({
     sources: { stripe: source },
-    destinations: { postgres: pgDestination, 'google_sheets': sheetsDestination },
+    destinations: { postgres: pgDestination, google_sheets: sheetsDestination },
   })
   const app = await createApp(resolver)
 

apps/engine/src/lib/createSchemas.ts

@@ -73,19 +73,25 @@ export function createConnectorSchemas(resolver: ConnectorResolver) {
     return { name, config, variant: z.object({ type: z.literal(name), [name]: config }) }
   })
 
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   const SourceConfig =
     sources.length > 0
       ? z
-          .discriminatedUnion('type', sources.map((s) => s.variant) as [any, any, ...any[]])
+          .discriminatedUnion(
+            'type',
+            // eslint-disable-next-line @typescript-eslint/no-explicit-any
+            sources.map((s) => s.variant) as [any, any, ...any[]]
+          )
           .meta({ id: connectorUnionId('Source') })
       : z.object({ type: z.string() }).catchall(z.unknown())
 
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   const DestinationConfig =
     destinations.length > 0
       ? z
-          .discriminatedUnion('type', destinations.map((d) => d.variant) as [any, any, ...any[]])
+          .discriminatedUnion(
+            'type',
+            // eslint-disable-next-line @typescript-eslint/no-explicit-any
+            destinations.map((d) => d.variant) as [any, any, ...any[]]
+          )
           .meta({ id: connectorUnionId('Destination') })
       : z.object({ type: z.string() }).catchall(z.unknown())
 

apps/engine/src/lib/default-connectors.ts

@@ -8,6 +8,6 @@ export const defaultConnectors: RegisteredConnectors = {
   sources: { stripe: sourceStripe },
   destinations: {
     postgres: destinationPostgres,
-    'google_sheets': destinationGoogleSheets,
+    google_sheets: destinationGoogleSheets,
   },
 }

apps/engine/src/lib/exec.test.ts

@@ -3,7 +3,6 @@ import { resolveBin } from './resolver.js'
 import { createSourceFromExec } from './source-exec.js'
 import { createDestinationFromExec } from './destination-exec.js'
 import { collectFirst } from '@stripe/sync-protocol'
-import type { Message } from '@stripe/sync-protocol'
 
 // These tests use real connector binaries (built by `pnpm build`).
 

apps/engine/src/lib/pipeline.test.ts

@@ -64,7 +64,10 @@ describe('enforceCatalog()', () => {
     ]
     const result = await drain(enforceCatalog(catalog([{ name: 'customers' }]))(toAsync(msgs)))
     expect(result).toHaveLength(1)
-    expect((result[0] as any).record.data).toEqual({ id: 'cus_1', name: 'Alice' })
+    expect((result[0] as { record: { data: unknown } }).record.data).toEqual({
+      id: 'cus_1',
+      name: 'Alice',
+    })
   })
 
   it('filters record fields to json_schema.properties when present', async () => {
@@ -92,7 +95,10 @@ describe('enforceCatalog()', () => {
       )(toAsync(msgs))
     )
     expect(result).toHaveLength(1)
-    expect((result[0] as any).record.data).toEqual({ id: 'sub_1', status: 'active' })
+    expect((result[0] as { record: { data: unknown } }).record.data).toEqual({
+      id: 'sub_1',
+      status: 'active',
+    })
   })
 
   it('drops unknown internal fields that are not present in the catalog schema', async () => {
@@ -126,7 +132,7 @@ describe('enforceCatalog()', () => {
       )(toAsync(msgs))
     )
     expect(result).toHaveLength(1)
-    expect((result[0] as any).record.data).toEqual({
+    expect((result[0] as { record: { data: unknown } }).record.data).toEqual({
       id: 'sub_1',
       status: 'active',
     })
@@ -145,7 +151,7 @@ describe('enforceCatalog()', () => {
     ]
     const result = await drain(enforceCatalog(catalog([{ name: 'subscriptions' }]))(toAsync(msgs)))
     expect(result).toHaveLength(1)
-    expect((result[0] as any).record.data).toEqual({
+    expect((result[0] as { record: { data: unknown } }).record.data).toEqual({
       id: 'sub_1',
       status: 'active',
       customer: 'cus_1',

apps/engine/src/lib/remote-engine.test.ts

@@ -6,6 +6,7 @@ import { sourceTest, destinationTest, collectFirst } from './index.js'
 import { createApp } from '../api/app.js'
 import { createRemoteEngine } from './remote-engine.js'
 import type { PipelineConfig, SourceStateMessage } from '@stripe/sync-protocol'
+import { z } from 'zod'
 
 // ---------------------------------------------------------------------------
 // Server setup
@@ -54,7 +55,7 @@ beforeAll(async () => {
           'test',
           {
             connector: sourceTest,
-            configSchema: {} as any,
+            configSchema: z.object({}),
             rawConfigJsonSchema: srcConfigSchema,
           },
         ],
@@ -65,7 +66,7 @@ beforeAll(async () => {
           'test',
           {
             connector: destinationTest,
-            configSchema: {} as any,
+            configSchema: z.object({}),
             rawConfigJsonSchema: destConfigSchema,
           },
         ],

apps/engine/src/lib/resolver.ts

@@ -1,7 +1,7 @@
 import { existsSync, readFileSync } from 'node:fs'
 import { dirname, join } from 'node:path'
 import { z } from 'zod'
-import type { Source, Destination, ConnectorSpecification } from '@stripe/sync-protocol'
+import type { Source, Destination } from '@stripe/sync-protocol'
 import { collectFirst } from '@stripe/sync-protocol'
 import { createSourceFromExec } from './source-exec.js'
 import { createDestinationFromExec } from './destination-exec.js'