harden logger

Author: Yostra

apps/engine/src/api/app.ts

@@ -37,6 +37,7 @@ const ndjsonRef = {
   SourceInputMessage: { $ref: '#/components/schemas/SourceInputMessage' },
 }
 import { ndjsonResponse } from '@stripe/sync-ts-cli/ndjson'
+import { REQUEST_HEADER_REDACT } from '@stripe/sync-logger'
 import { logger } from '../logger.js'
 import {
   sslConfigFromConnectionString,
@@ -142,28 +143,22 @@ export async function createApp(resolver: ConnectorResolver) {
         }
       })
       logger.debug(
-        { requestId, method: c.req.method, path: c.req.path, headers },
+        { requestId, method: c.req.method, path: c.req.path, request_headers: headers },
         'request headers'
       )
     }
     logger.info({ requestId, method: c.req.method, path: c.req.path }, 'request start')
     if (dangerouslyVerbose) {
       const curlParts = [`curl -X ${c.req.method} '${c.req.url}'`]
       c.req.raw.headers.forEach((value, key) => {
-        curlParts.push(`  -H '${key}: ${value}'`)
+        curlParts.push(
+          REQUEST_HEADER_REDACT.has(key.toLowerCase())
+            ? `  -H '${key}: [REDACTED]'`
+            : `  -H '${key}: ${value}'`
+        )
       })
       if (hasBody(c)) {
-        const cl = c.req.header('Content-Length')
-        if (cl && Number(cl) < 100_000) {
-          try {
-            const body = await c.req.raw.clone().text()
-            curlParts.push(`  -d '${body.replace(/'/g, "'\\''")}'`)
-          } catch {
-            /* skip */
-          }
-        } else {
-          curlParts.push('  --data-binary @-')
-        }
+        curlParts.push('  --data-binary @-')
       }
       logger.debug(curlParts.join(' \\\n'))
     }

apps/engine/src/logger.ts

@@ -1,3 +1,3 @@
 import { createLogger } from '@stripe/sync-logger'
 
-export const logger = createLogger({ name: 'engine', pretty: !!process.env.LOG_PRETTY })
+export const logger = createLogger({ name: 'engine' })

apps/service/src/temporal/activities/pipeline-sync.ts

@@ -1,5 +1,6 @@
 import { ApplicationFailure } from '@temporalio/activity'
 import type { SourceInputMessage, SourceReadOptions } from '@stripe/sync-engine'
+import { logger } from '../../logger.js'
 import type { ActivitiesContext } from './_shared.js'
 import { asIterable, drainMessages, type RunResult } from './_shared.js'
 import { classifySyncErrors, summarizeSyncErrors } from '../sync-errors.js'
@@ -33,7 +34,8 @@ export function createPipelineSyncActivity(context: ActivitiesContext) {
     const { transient, permanent } = classifySyncErrors(errors)
     if (permanent.length > 0) {
       if (transient.length > 0) {
-        console.warn(
+        logger.warn(
+          { transientCount: transient.length, permanentCount: permanent.length },
           `Transient errors suppressed by permanent failures: ${summarizeSyncErrors(transient)}`
         )
       }

packages/destination-postgres/package.json

@@ -23,6 +23,7 @@
     "src"
   ],
   "dependencies": {
+    "@stripe/sync-logger": "workspace:*",
     "@stripe/sync-protocol": "workspace:*",
     "@stripe/sync-util-postgres": "workspace:*",
     "pg": "^8.16.3",

packages/destination-postgres/src/index.ts

@@ -1,6 +1,7 @@
 import pg from 'pg'
 import type { PoolConfig } from 'pg'
 import type { Destination, DestinationInput, LogMessage } from '@stripe/sync-protocol'
+import { createConnectorLogger } from '@stripe/sync-logger'
 import {
   sql,
   sslConfigFromConnectionString,
@@ -13,6 +14,8 @@ import { buildCreateTableDDL } from './schemaProjection.js'
 import defaultSpec from './spec.js'
 import type { Config } from './spec.js'
 
+const logger = createConnectorLogger('destination-postgres')
+
 function logMsg(message: string, level: LogMessage['log']['level'] = 'info'): LogMessage {
   return { type: 'log', log: { level, message } }
 }
@@ -109,7 +112,7 @@ function createPool(config: PoolConfig): pg.Pool {
   const pool = new pg.Pool(config)
   // Destination connectors should surface pool failures without crashing the host process.
   pool.on('error', (err) => {
-    console.error('Postgres destination pool error:', err)
+    logger.error({ err }, 'Postgres destination pool error')
   })
   return pool
 }

packages/logger/src/index.ts

@@ -1,6 +1,7 @@
 export {
   createLogger,
   createConnectorLogger,
+  REQUEST_HEADER_REDACT,
   type CreateLoggerOptions,
   type Logger,
 } from './logger.js'