diff --git a/burr/core/action.py b/burr/core/action.py index eb6fceff5..5a228e0ad 100644 --- a/burr/core/action.py +++ b/burr/core/action.py @@ -243,16 +243,12 @@ def validate_inputs(self, inputs: Optional[Dict[str, Any]]) -> None: missing_inputs = required_inputs - given_inputs additional_inputs = given_inputs - required_inputs - optional_inputs if missing_inputs or additional_inputs: - raise ValueError( - f"Inputs to function {self} are invalid. " - + f"Missing the following inputs: {', '.join(missing_inputs)}." - if missing_inputs - else ( - "" f"Additional inputs: {','.join(additional_inputs)}." - if additional_inputs - else "" - ) - ) + parts = [f"Inputs to function {self} are invalid."] + if missing_inputs: + parts.append(f"Missing the following inputs: {', '.join(missing_inputs)}.") + if additional_inputs: + parts.append(f"Additional inputs: {', '.join(additional_inputs)}.") + raise ValueError(" ".join(parts)) def is_async(self) -> bool: """Convenience method to check if the function is async or not. diff --git a/burr/core/graph.py b/burr/core/graph.py index 871135962..b31e1cab6 100644 --- a/burr/core/graph.py +++ b/burr/core/graph.py @@ -95,20 +95,20 @@ def _render_graphviz( if output_file_path.suffix != "": # infer format from path; i.e., extract `svg` from the `.svg` suffix - format = output_file_path.suffix.partition(".")[-1] + fmt = output_file_path.suffix.partition(".")[-1] else: - format = "png" + fmt = "png" path_without_suffix = pathlib.Path(output_file_path.parent, output_file_path.stem) if write_dot or view: # `.render()` appends the `format` kwarg to the filename # i.e., we need to pass `/my/filepath` to generate `/my/filepath.png` # otherwise, passing `/my/filepath.png` will generate `/my/filepath.png.png` - graphviz_obj.render(path_without_suffix, format=format, view=view) + graphviz_obj.render(path_without_suffix, format=fmt, view=view) else: # `.pipe()` doesn't append the format to the filename, so we do it explicitly - pathlib.Path(f"{path_without_suffix}.{format}").write_bytes( - graphviz_obj.pipe(format=format) + pathlib.Path(f"{path_without_suffix}.{fmt}").write_bytes( + graphviz_obj.pipe(format=fmt) ) diff --git a/burr/integrations/persisters/b_aiosqlite.py b/burr/integrations/persisters/b_aiosqlite.py index a75eb682c..8439b965b 100644 --- a/burr/integrations/persisters/b_aiosqlite.py +++ b/burr/integrations/persisters/b_aiosqlite.py @@ -26,7 +26,7 @@ from burr.core import State from burr.core.persistence import AsyncBaseStatePersister, PersistedStateData -logger = logging.getLogger() +logger = logging.getLogger(__name__) try: from typing import Self