Swift overloads produce uncompilable wrappers

[timofeys1]

Reproduction

It seems that overloads currently produce incorrect Java code. This is reproducible by creating:

public class OverloadSample {
    public func takeValue(a: String) {}
    public func takeValue(b: String) {}
}

in Samples/SwiftJavaExtractFFMSampleApp/Sources/MySwiftLibrary/OverloadSample.swift and running ./gradlew :Samples:SwiftJavaExtractFFMSampleApp:compileJava.

The compilation fails with:

OverloadSample.java:129: error: method takeValue(String) is already defined in class OverloadSample
    public void takeValue(java.lang.String b) {

[ktoso]

Yeah thanks for the issue, we didn’t get to solving that yet.

The solution will be have to be uniqueing them perhaps by including parameter names from the swift signature etc

[Clemo97]

Hello @ktoso , I'll pick up this issue

[ktoso]

Awesome, thank you!

[sidepelican]

#629 solved this?

[ktoso]

Right, thanks :)