[DeepClone] Fix cloning objects with numeric property names#626
Merged
Conversation
nicolas-grekas
force-pushed
the
deepclone-numeric-props
branch
from
5f2c6e6 to
fb7b36d
Compare
A numeric property name (e.g. $o->{'999'}) round-trips through serialize()
but deepclone_from_array() rejected the integer array key PHP produces when
normalizing it. Accept numeric property names, matching the extension and
unserialize().
Fixes symfony/symfony#64548.
nicolas-grekas
force-pushed
the
deepclone-numeric-props
branch
from
fb7b36d to
1853d9c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A numeric property name like
$o->{'999'}round-trips throughserialize(), butdeepclone_from_array()rejected the integer array key PHP produces when normalizing it (to_array()already emits it as an int via the(array)cast). Accept numeric property names, matchingunserialize()and the extension.Companion extension fix: symfony/php-ext-deepclone#18.