chore: upgrade to agp 9 and configure parallelism

[ovitrif]

Parent: #1113
Depends on: #1115

Goal

Upgrade Bitkit Android to the stable AGP 9 toolchain, adopt built-in Kotlin and the public AGP DSL, replace internal variant/output hooks with supported artifact APIs, and explicitly enable Gradle task and Android Studio Tooling API parallelism.

Preparation

• Update Android CLI and install or refresh the official agp-9-upgrade skill before refinement and implementation.
• Use the skill's current AGP 9 migration guidance and primary Android documentation retrieved through android docs as the implementation contract.
• Start from chore: update kotlin and compose bom #1115's landed Kotlin/Compose baseline and run Android Studio's AGP Upgrade Assistant from that current master state.

Compatibility matrix

Component	Required state
Android Gradle Plugin	9.3.0
Gradle	9.5.0
JDK	CI 17; Android Studio JetBrains Runtime 21
Kotlin / Compose BOM	Consume the versions landed by #1115; Kotlin 2.3.21 or newer
KSP	2.3.10
Hilt	2.60.1
SDK	compile/target 36; min 28
JVM target	11
NDK	default 28.1.13356709 with NDK_VERSION override

Deliverables

Toolchain and public DSL

• Run Android Studio's AGP Upgrade Assistant from the landed chore: update kotlin and compose bom #1115 baseline and retain its report in the PR evidence.
• Upgrade AGP, Gradle wrapper, KSP, and Hilt to the matrix above.
• Remove org.jetbrains.kotlin.android; retain the Compose compiler and serialization plugins.
• Move compiler configuration to built-in Kotlin's supported kotlin.compilerOptions DSL while preserving -XXLanguage:+PropertyParamAnnotationDefaultTargetMode and JVM 11.
• Keep buildFeatures.buildConfig = true; enable buildFeatures.resValues = true.
• Adopt AGP 9 built-in Kotlin and the new public DSL directly.
• Replace all com.android.build.gradle.internal and applicationVariants integrations.

Generated values

• Move repository-defined BuildConfig values to androidComponents.onVariants through public BuildConfigField providers.
• Preserve E2E, E2E_BACKEND, E2E_HOMEGATE_URL, TREZOR_BRIDGE, TREZOR_BRIDGE_URL, GEO, FEATURE_PAYKIT_UI_DISABLED, LOCALES, and flavor-specific NETWORK.
• Preserve dev/mainnet/tnet app_name resources and tracked, lazy provider inputs.

Public artifact collection

• Replace BaseVariantOutputImpl, FinalizeBundleTask, and applicationVariants.all output renaming.
• Read APK metadata through SingleArtifact.APK and BuiltArtifactsLoader; read AABs through SingleArtifact.BUNDLE.
• Keep AGP-native outputs and publish deterministic copies under app/build/outputs/bitkit/<variant>/:
  • bitkit-{flavor}-{buildType}-{versionCode}-{abi}.apk
  • bitkit-{flavor}-{buildType}-{versionCode}.aab
• Derive universal, armeabi-v7a, arm64-v8a, and debug x86_64 names from AGP metadata.
• Declare task inputs/outputs and retain configuration-cache and build-cache compatibility.

Consumers and build properties

• Update just run, just release, E2E workflows, internal/stable release workflows, directly coupled README/release-command paths, and focused build-contract tests.
• Preserve signing, ABI filters, stripping checks, native debug symbols, signatures, checksums, and Play/GitHub publication names.
• Use these properties exactly once:

org.gradle.daemon=true
org.gradle.parallel=true
org.gradle.tooling.parallel=true
org.gradle.caching=true
org.gradle.configuration-cache=true

Acceptance criteria

• Android Studio sync succeeds after the Upgrade Assistant migration.
• ./gradlew --version reports Gradle 9.5.0 on JDK 17.
• The catalog reports AGP 9.3.0, KSP 2.3.10, Hilt 2.60.1, and the Kotlin/Compose versions landed by chore: update kotlin and compose bom #1115.
• Build logic no longer applies org.jetbrains.kotlin.android or uses internal/legacy AGP variant APIs.
• Existing BuildConfig and flavor resources match the AGP 8 baseline for every flavor.
• Assemble/bundle tasks produce native artifacts and publication copies with the established names.
• ./gradlew help --warning-mode=all reports no repository-owned toolchain deprecations.
• ./gradlew build --dry-run resolves dev, tnet, and mainnet variants.
• Two consecutive ./gradlew help runs store and reuse the configuration cache.
• Android Studio sync succeeds with Tooling API parallelism explicitly enabled.
• just compile, just test, just lint, just build, and just test android pass.
• The dev smoke journey, local E2E, and release artifact/signature/symbol/checksum validation pass.
• actionlint passes for workflow edits.
• GitHub-hosted CI, E2E, internal-release, and stable-release paths consume the collected outputs in workflows triggered after merge.

References

• AGP 9.3.0 release notes
• AGP requirements for Kotlin versions
• Built-in Kotlin migration
• AGP 9.3 Gradle recipes
• Gradle Tooling API parallelism
• Contributor compatibility findings

[ovitrif]

Set to milestone 2.5.0 due to the persisting issue while this is not resolved:
Opening the app project in latest Android Studio keeps re-creating local diff to specify the now-required explicit parallelism config.

[guzino]

The AGP 9.3.0 / Gradle 9.5.0 toolchain lands, but the compatibility matrix cannot hold as written: Kotlin 2.2.21 and AGP 9 built-in Kotlin are mutually exclusive.

What works

On top of efc9bcd65, with AGP 9.3.0, Gradle 9.5.0, KSP 2.3.10, Hilt 2.60.1:

• ./gradlew help configures. --warning-mode=all leaves one deprecation, ReportingExtension.file(String), which comes from detekt 1.23.8 and not from this repo.
• Two consecutive ./gradlew help runs store then reuse the configuration cache.
• android.nonFinalResIds=false is deprecated with a default of true and has to be dropped.
• The BuildConfig move to androidComponents.onVariants and the SingleArtifact.APK / SingleArtifact.BUNDLE collection tasks configure without any reference to com.android.build.gradle.internal.

Kotlin 2.2.21 does not compile under built-in Kotlin

compileDevDebugKotlin fails in the IR backend:

Internal error in file lowering: java.lang.AssertionError: Error occurred while optimizing an expression:
CALL 'public final fun toUShort (<this>: kotlin.Int): kotlin.UShort [inline] declared in kotlin.UShortKt'
  ARG <this>: CONST Int type=kotlin.Int value=4617
Caused by: org.jetbrains.kotlin.ir.interpreter.exceptions.InterpreterMethodNotFoundError: Unknown function: toUShort(kotlin.Int)

Built-in Kotlin runs the IR const-evaluation transformer over ordinary code, and the 2.2.21 interpreter has no entry for the unsigned conversions. Two sites hit it so far: TREZOR_VENDOR_ID.toUShort() in TrezorBridgeTransport.kt and 3600.toULong() in CoreService.kt. Any const-folded unsigned conversion is a candidate, so patching call sites is not a fix. That the const-evaluation pass is what built-in Kotlin newly enables is inferred from the stack, not from a compiler flag: the resolved argument list contains no const-evaluation option.

Ruled out one at a time, each with a full compileDevDebugKotlin:

• -XXLanguage:+PropertyParamAnnotationDefaultTargetMode removed, same crash.
• compose-stability-analyzer removed, same crash.
• KSP 2.3.5 instead of 2.3.10, same crash.
• android.enableAppCompileTimeRClass=false, same crash.
• Same sources on efc9bcd65 with AGP 8.13.2 and Gradle 8.13, BUILD SUCCESSFUL.

The KSP pin already implies Kotlin 2.3

KSP	kotlin-stdlib
2.3.5	2.2.10
2.3.6	2.3.0
2.3.7 to 2.3.10	2.3.20

KSP 2.3.10 is built against Kotlin 2.3.20, and the agp-9-upgrade skill's floor of KSP 2.3.6 is already past the 2.2 line. The matrix pins 2.3.10 and 2.2.21 together.

The set that compiles

AGP 9.3.0, Gradle 9.5.0, KSP 2.3.10, Hilt 2.60.1, Kotlin 2.3.21, compose-stability-analyzer 0.8.0, Compose BOM 2025.12.01 unchanged: compileDevDebugKotlin BUILD SUCCESSFUL.

The analyzer has to move with Kotlin. 0.6.6 throws NoSuchMethodError on IrDeclarationOrigin.IR_EXTERNAL_DECLARATION_STUB, 0.12.0 throws NoClassDefFoundError on FirExtensionRegistrarConfigurationUtilKt, 0.8.0 targets Kotlin 2.3.21.

I verified compilation only on that set. just test, just lint, just build, the release artifact names and the workflow consumers are unverified.

So #1114 cannot land ahead of the Kotlin upgrade. Either the sibling Kotlin issue goes first and #1114 rebases onto it, or this issue absorbs Kotlin 2.3.21 plus the analyzer bump and the matrix is corrected. That ordering call belongs to the 2.5.0 milestone owner.

[ovitrif]

Agreed. I reordered the maintenance sequence around this compatibility finding.

#1115 now lands first on current AGP 8.13.2, which officially supports Kotlin 2.3, and establishes Kotlin 2.3.21 or newer with the compatible Compose set. This issue now depends on #1115 and consumes that landed baseline before upgrading AGP, Gradle, KSP, and Hilt.

The epic dependency order and both child specifications now reflect this sequence.