feat(portal): add PWA support to desktop Blazor client#489
Conversation
|
Farnsworth review — PR #489
LGTM. Ready to merge. |
|
CI: All checks passing LGTM - ready to merge. |
sytone
left a comment
There was a problem hiding this comment.
Farnsworth Review — PR #489
CI: ✅ All checks passing
Merge conflicts: ✅ Clean (MERGEABLE)
Conventional commit title: ✅ feat(portal): add PWA support to desktop Blazor client
Test coverage:
- ✅ 12 PwaAssetsTests (manifest exists, service workers, csproj config, index.html meta)
- 1636 gateway + 349 BlazorClient pass
Spec completeness vs #239: Full PWA manifest, service workers (dev passthrough + offline-first published), index.html meta tags. Icons are placeholder indigo squares — flag for brand asset replacement before final release.
Note: /hub/ and /api/ correctly excluded from service worker cache.
LGTM. Ready to merge.
|
Closing as part of a planned hard-reset of the in-flight branch set so the new domain-model refactor can land on a clean trunk. Audit verdict: keep Rationale: Portal/UI. No domain impact. The new plan (in session state) reshapes core types: Citizen (User+Agent union), Vogen-generated value objects, ThreadId removed in favour of composite ChannelAddress, mark-not-delete compaction, centralised If this work is still wanted, refile as a new issue/PR against the post-refactor contracts. |
Closes #239
Changes
manifest.webmanifestmanifest.webmanifestwith required PWA fields: name, short_name, start_url, display, theme_color, background_color, iconsmaskablepurpose on 512service-worker.js(dev)service-worker.published.js(production)service-worker-assets.js.dll,.wasm,.html,.js,.css,.svg,.png,.webmanifestassets/hub/and/api/requests (must reach live server)BotNexus.Extensions.Channels.SignalR.BlazorClient.csproj<ServiceWorkerAssetsManifest>service-worker-assets.js</ServiceWorkerAssetsManifest><ServiceWorker>item to wire dev/published service workersindex.html<link rel="manifest" href="manifest.webmanifest" />theme-color,mobile-web-app-capable,apple-mobile-web-app-*meta tags<link rel="apple-touch-icon">for iOS home screen iconIcons
icon-192.pngandicon-512.pnggenerated as indigo (#4f46e5) placeholder icons with "BN" textTests (12 new)
PwaAssetsTests.cs-- verifies all PWA assets exist and manifest has required fieldsAll 1636 gateway + 349 BlazorClient + 206 CodingAgent tests pass.