Skip to content

feat(portal): add agents sidebar sub-tree and per-agent route#491

Closed
sytone wants to merge 1 commit into
mainfrom
feat/agent-sidebar
Closed

feat(portal): add agents sidebar sub-tree and per-agent route#491
sytone wants to merge 1 commit into
mainfrom
feat/agent-sidebar

Conversation

@sytone
Copy link
Copy Markdown
Owner

@sytone sytone commented May 22, 2026

Part of #407 (Phase 1 of 3)

Changes

  • Agents nav item in sidebar becomes expand/collapse sub-tree
  • Sub-tree lists all registered agents with links to /agents/{agentId}
  • Auto-expands when navigating to any /agents/* route
  • Live refresh on Hub.OnAgentsChanged
  • /agents/{agentId} route renders detail placeholder (Phase 2 will add full panel)
  • /agents/new route auto-opens the add-agent form

Test coverage (5 new tests)

  • AgentId param set renders detail placeholder
  • AgentId null renders table view
  • AgentId=new shows add form
  • Agents sidebar subnav not shown when not on agents page
  • AgentsSidebar_ExpandsWhenOnAgentsRoute

Phase 1 of #407: sidebar expand/collapse with per-agent links,
per-agent URL routing /agents/{agentId}, /agents/new shortcut,
auto-expand on agents/* routes, live refresh on Hub.OnAgentsChanged.

Part of #407
@sytone
Copy link
Copy Markdown
Owner Author

sytone commented May 22, 2026

Farnsworth Review — PR #491

  • CI: ✅ All checks passing (build-and-test, CodeQL, TruffleHog, patterns, deps)
  • Merge conflicts: ✅ CLEAN / MERGEABLE
  • Commit title: feat(portal): add agents sidebar sub-tree and per-agent route ✅ conventional
  • Test coverage: 5 new tests — detail placeholder when agentId set, table view when null, add-form on agentId=new, sidebar not shown off-agents-route, auto-expand on agents route ✅
  • Spec completeness vs [Portal] Rich per-agent configuration panel with extension config blocks #407 Phase 1: Expand/collapse sidebar sub-tree, per-agent links, auto-expand on /agents/*, live OnAgentsChanged refresh, /agents/{agentId} placeholder route, /agents/new opens add form ✅
  • Design note: Placeholder for Phase 2 (full config panel) is the right incremental approach. OnAgentsChanged live refresh ensures sidebar stays consistent without polling.
  • Sub-issue of [Portal] Rich per-agent configuration panel with extension config blocks #407 (Phase 1 of 3)

LGTM. Ready to merge.

@sytone
Copy link
Copy Markdown
Owner Author

sytone commented May 22, 2026

CI: All checks passing
Merge conflicts: Clean / MERGEABLE
Commit title: Conventional commit format correct
Coverage: 5 new tests - AgentsPageTests (sidebar, expand/collapse, per-agent links, auto-expand on /agents/* route)
Spec completeness: Part of #407 Phase 1 - agents sidebar sub-tree with expand/collapse, per-agent links, auto-expand on matching routes, live refresh on Hub.OnAgentsChanged

LGTM - ready to merge.

@sytone
Copy link
Copy Markdown
Owner Author

sytone commented May 22, 2026

CI: ✅ All checks passing
Merge: CLEAN — no conflicts
Commit title: feat(portal): add agents sidebar sub-tree and per-agent route ✅ Conventional commit
Coverage: 5 bunit tests covering expand/collapse, route auto-expand, live refresh
Spec completeness: Closes #407 Phase 1 — agents sidebar with per-agent links, auto-expand on /agents/* routes

LGTM — ready to merge.

Copy link
Copy Markdown
Owner Author

@sytone sytone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Farnsworth Review — PR #491

CI: ✅ All checks passing
Merge conflicts: ✅ Clean (MERGEABLE)
Conventional commit title:feat(portal): add agents sidebar sub-tree and per-agent route

Test coverage:

  • ✅ 5 new tests (expand/collapse, per-agent links, auto-expand on route)
  • MainLayoutTests updated
  • Full suite passes clean

Spec completeness vs #407 Phase 1: Sidebar sub-tree with live refresh and /agents/{agentId} route satisfies Phase 1. Auto-expand on /agents/* routes is good UX.

LGTM. Ready to merge.

@sytone
Copy link
Copy Markdown
Owner Author

sytone commented May 22, 2026

Closing as part of a planned hard-reset of the in-flight branch set so the new domain-model refactor can land on a clean trunk.

Audit verdict: keep

Rationale: Portal/UI. No domain impact.

The new plan (in session state) reshapes core types: Citizen (User+Agent union), Vogen-generated value objects, ThreadId removed in favour of composite ChannelAddress, mark-not-delete compaction, centralised SessionContextProjector, single-path routing. Many in-flight branches touch contracts that are about to change — rebasing later would be more work than rebuilding on the new shape.

If this work is still wanted, refile as a new issue/PR against the post-refactor contracts.

@sytone sytone closed this May 22, 2026
@sytone sytone deleted the feat/agent-sidebar branch May 22, 2026 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant