feat(portal): add agents sidebar sub-tree and per-agent route#491
feat(portal): add agents sidebar sub-tree and per-agent route#491sytone wants to merge 1 commit into
Conversation
Farnsworth Review — PR #491
LGTM. Ready to merge. |
|
CI: All checks passing LGTM - ready to merge. |
|
CI: ✅ All checks passing LGTM — ready to merge. |
sytone
left a comment
There was a problem hiding this comment.
Farnsworth Review — PR #491
CI: ✅ All checks passing
Merge conflicts: ✅ Clean (MERGEABLE)
Conventional commit title: ✅ feat(portal): add agents sidebar sub-tree and per-agent route
Test coverage:
- ✅ 5 new tests (expand/collapse, per-agent links, auto-expand on route)
- MainLayoutTests updated
- Full suite passes clean
Spec completeness vs #407 Phase 1: Sidebar sub-tree with live refresh and /agents/{agentId} route satisfies Phase 1. Auto-expand on /agents/* routes is good UX.
LGTM. Ready to merge.
|
Closing as part of a planned hard-reset of the in-flight branch set so the new domain-model refactor can land on a clean trunk. Audit verdict: keep Rationale: Portal/UI. No domain impact. The new plan (in session state) reshapes core types: Citizen (User+Agent union), Vogen-generated value objects, ThreadId removed in favour of composite ChannelAddress, mark-not-delete compaction, centralised If this work is still wanted, refile as a new issue/PR against the post-refactor contracts. |
Part of #407 (Phase 1 of 3)
Changes
/agents/{agentId}/agents/*routeHub.OnAgentsChanged/agents/{agentId}route renders detail placeholder (Phase 2 will add full panel)/agents/newroute auto-opens the add-agent formTest coverage (5 new tests)
AgentIdparam set renders detail placeholderAgentIdnull renders table viewAgentId=newshows add formAgentsSidebar_ExpandsWhenOnAgentsRoute