fix(tests): parse changelog version with Select-String instead of break in ForEach-Object (#37)

* fix(tests): parse changelog version with Select-String instead of break in ForEach-Object

The BeforeAll changelog-version parse in tests/Manifest.tests.ps1 used
`Get-Content $changelogPath | ForEach-Object { ... break }`. `break` inside
ForEach-Object is unreliable: a pipeline is not a loop, so `break` targets an
enclosing loop if one exists, or otherwise terminates the block unexpectedly,
rather than cleanly stopping at the first match. Replace it with Select-String,
which returns the first matching line's named capture group directly — no loop
and no break.

Behavior is unchanged (still resolves to the topmost `## [Version]` entry).
Surfaced while aligning a downstream module's Manifest test
(tablackburn/ReScenePS#22).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* fix(tests): guard changelog version parse against no match

Capture the Select-String MatchInfo before indexing so a missing or malformed changelog heading leaves $changelogVersion as $null and fails the assertion cleanly, instead of throwing "Cannot index into a null array" in BeforeAll.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: tablackburn

tests/Manifest.tests.ps1

@@ -140,11 +140,15 @@ BeforeAll {
     # Parse the version from the changelog
     $changelogPath = Join-Path -Path $Env:BHProjectPath -ChildPath 'CHANGELOG.md'
     $changelogVersionPattern = '^##\s\\?\[(?<Version>(\d+\.){1,3}\d+)\\?\]' # Matches on a line that starts with '## [Version]' or '## \[Version\]'
-    $changelogVersion = Get-Content $changelogPath | ForEach-Object {
-        if ($_ -match $changelogVersionPattern) {
-            $changelogVersion = $matches.Version
-            break
-        }
+    # Select-String returns the first matching line's named capture directly — no loop and no
+    # 'break' (which is unreliable inside ForEach-Object, since a pipeline is not a loop).
+    # Capture the MatchInfo first and guard for no match, so a missing or malformed changelog
+    # heading leaves $changelogVersion as $null (failing the assertion below cleanly) instead of
+    # throwing "Cannot index into a null array" here in BeforeAll.
+    $changelogMatch = Select-String -Path $changelogPath -Pattern $changelogVersionPattern |
+        Select-Object -First 1
+    $changelogVersion = if ($changelogMatch) {
+        $changelogMatch.Matches[0].Groups['Version'].Value
     }
 }
 Describe 'Module manifest' {