What's the purpose of isArray?

[ryandesign]

What's the purpose of isArray? It doesn't seem to be used anywhere. Can it be removed?

[tan-tan-kanarek]

It's used, here are few examples:

github-php-client/client/services/GitHubIssuesLabels.php

Line 20 in 83d80d7

return $this->client->request("/repos/$owner/$repo/labels", 'GET', $data, 200, 'GitHubLabel', true);

github-php-client/client/services/GitHubPulls.php

Line 61 in 83d80d7

return $this->client->request("/repos/$owner/$repo/pulls", 'GET', $data, 200, 'GitHubPull', true);

github-php-client/client/services/GitHubOrgsTeams.php

Line 23 in 83d80d7

return $this->client->request("/orgs/$org/teams", 'GET', $data, 200, 'GitHubTeam', true);

github-php-client/client/services/GitHubGistsComments.php

Line 20 in 83d80d7

return $this->client->request("/gists/$gist_id/comments", 'GET', $data, 200, 'GitHubGistComment', true);

github-php-client/client/services/GitHubOrgsMembers.php

Line 20 in 83d80d7

return $this->client->request("/orgs/$org/members", 'GET', $data, 200, 'GitHubUser', true);

github-php-client/client/services/GitHubReposCollaborators.php

Line 19 in 12412cc

return $this->client->request("/repos/$owner/$repo/collaborators", 'GET', $data, 200, 'GitHubUser', true);

[ryandesign]

Ok, those lines of code set the isArray parameter of the request method to true instead of the default of false. But then what happens? request and the rest of GitHubClientBase don't appear to use isArray to do anything different.

[tan-tan-kanarek]

You're right, I don't use it anymore.
It could be removed, same as lastReturnIsArray, but we will have to modify all the methods that use request method.