chore: 采纳 Greptile 建议整理测试工具并增强日志

- 抽出 tests/helpers/env.ts 避免重复 env snapshot\n- drop invalid update 日志增加 isTerminal 且按终态提升严重级别\n- 补充注释说明 loadLastRequests 仅返回有完成记录的用户

Author: tesgth032

src/lib/proxy-status-tracker.ts

@@ -199,6 +199,7 @@ export class ProxyStatusTracker {
     // 注意：该接口需要返回所有用户状态，因此整体复杂度与 users 数量线性相关。
     // 这里使用 LATERAL + 索引扫描来避免在 message_request 大表上做全表排序去重（DISTINCT ON），
     // 若未来用户规模显著增大（例如 1e4+），建议为该接口增加分页/按需查询，或引入专门的汇总表/物化视图。
+    // 本查询仅返回“存在已结束请求”的用户；其余用户由 getAllUsersStatus 补齐 lastRequest=null。
     const query = sql<LastRequestRow>`
       SELECT
         u.id AS "userId",

src/repository/message-write-buffer.ts

@@ -970,8 +970,11 @@ class MessageRequestWriteBuffer {
       }
 
       if (lastFailure) {
-        logger.error("[MessageRequestWriteBuffer] Dropping invalid update to unblock queue", {
+        const isTerminal = isTerminalPatch(item.patch);
+        const log = isTerminal ? logger.error : logger.warn;
+        log("[MessageRequestWriteBuffer] Dropping invalid update to unblock queue", {
           requestId: item.id,
+          isTerminal,
           keys: Object.keys(item.patch),
           types: summarizePatchTypes(item.patch),
           sample: (() => {

tests/helpers/env.ts

@@ -0,0 +1,19 @@
+export type EnvSnapshot = Record<string, string | undefined>;
+
+export function snapshotEnv(keys: string[]): EnvSnapshot {
+  const snapshot: EnvSnapshot = {};
+  for (const key of keys) {
+    snapshot[key] = process.env[key];
+  }
+  return snapshot;
+}
+
+export function restoreEnv(snapshot: EnvSnapshot): void {
+  for (const [key, value] of Object.entries(snapshot)) {
+    if (value === undefined) {
+      delete process.env[key];
+    } else {
+      process.env[key] = value;
+    }
+  }
+}

tests/unit/repository/message-orphaned-requests.test.ts

@@ -1,26 +1,7 @@
 import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
+import { restoreEnv, snapshotEnv } from "../../helpers/env";
 import { toSqlText } from "../../helpers/drizzle";
 
-type EnvSnapshot = Partial<Record<string, string | undefined>>;
-
-function snapshotEnv(keys: string[]): EnvSnapshot {
-  const snapshot: EnvSnapshot = {};
-  for (const key of keys) {
-    snapshot[key] = process.env[key];
-  }
-  return snapshot;
-}
-
-function restoreEnv(snapshot: EnvSnapshot) {
-  for (const [key, value] of Object.entries(snapshot)) {
-    if (value === undefined) {
-      delete process.env[key];
-    } else {
-      process.env[key] = value;
-    }
-  }
-}
-
 describe("sealOrphanedMessageRequests", () => {
   const envKeys = ["NODE_ENV", "DSN", "FETCH_BODY_TIMEOUT"];
   const originalEnv = snapshotEnv(envKeys);

tests/unit/repository/message-write-buffer.test.ts

@@ -1,26 +1,7 @@
 import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
+import { restoreEnv, snapshotEnv } from "../../helpers/env";
 import { toSqlText } from "../../helpers/drizzle";
 
-type EnvSnapshot = Partial<Record<string, string | undefined>>;
-
-function snapshotEnv(keys: string[]): EnvSnapshot {
-  const snapshot: EnvSnapshot = {};
-  for (const key of keys) {
-    snapshot[key] = process.env[key];
-  }
-  return snapshot;
-}
-
-function restoreEnv(snapshot: EnvSnapshot) {
-  for (const [key, value] of Object.entries(snapshot)) {
-    if (value === undefined) {
-      delete process.env[key];
-    } else {
-      process.env[key] = value;
-    }
-  }
-}
-
 function createDeferred<T>() {
   let resolve!: (value: T) => void;
   let reject!: (error: unknown) => void;