Skip to content

Commit ec4e5b4

Browse files
committed
Fix silent failure in BrowserWebDriverContainer#getSeleniumAddress
1 parent 2ac3c97 commit ec4e5b4

2 files changed

Lines changed: 2 additions & 4 deletions

File tree

modules/selenium/src/main/java/org/testcontainers/containers/BrowserWebDriverContainer.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -280,8 +280,7 @@ public URL getSeleniumAddress() {
280280
try {
281281
return new URL("http", getHost(), getMappedPort(SELENIUM_PORT), "/wd/hub");
282282
} catch (MalformedURLException e) {
283-
e.printStackTrace(); // TODO
284-
return null;
283+
throw new ContainerLaunchException("Could not construct Selenium address", e);
285284
}
286285
}
287286

modules/selenium/src/main/java/org/testcontainers/selenium/BrowserWebDriverContainer.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -179,8 +179,7 @@ public URL getSeleniumAddress() {
179179
try {
180180
return new URL("http", getHost(), getMappedPort(SELENIUM_PORT), "/wd/hub");
181181
} catch (MalformedURLException e) {
182-
e.printStackTrace(); // TODO
183-
return null;
182+
throw new ContainerLaunchException("Could not construct Selenium address", e);
184183
}
185184
}
186185

0 commit comments

Comments
 (0)