From ec4e5b4f35ee14e39fc784bbdf4f46ec9e295a5e Mon Sep 17 00:00:00 2001 From: dev-xong Date: Tue, 4 Aug 2026 16:20:58 +0900 Subject: [PATCH] Fix silent failure in BrowserWebDriverContainer#getSeleniumAddress --- .../testcontainers/containers/BrowserWebDriverContainer.java | 3 +-- .../org/testcontainers/selenium/BrowserWebDriverContainer.java | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/modules/selenium/src/main/java/org/testcontainers/containers/BrowserWebDriverContainer.java b/modules/selenium/src/main/java/org/testcontainers/containers/BrowserWebDriverContainer.java index 53ee8ba5577..8227f71c01a 100644 --- a/modules/selenium/src/main/java/org/testcontainers/containers/BrowserWebDriverContainer.java +++ b/modules/selenium/src/main/java/org/testcontainers/containers/BrowserWebDriverContainer.java @@ -280,8 +280,7 @@ public URL getSeleniumAddress() { try { return new URL("http", getHost(), getMappedPort(SELENIUM_PORT), "/wd/hub"); } catch (MalformedURLException e) { - e.printStackTrace(); // TODO - return null; + throw new ContainerLaunchException("Could not construct Selenium address", e); } } diff --git a/modules/selenium/src/main/java/org/testcontainers/selenium/BrowserWebDriverContainer.java b/modules/selenium/src/main/java/org/testcontainers/selenium/BrowserWebDriverContainer.java index 97ac23f5d55..af028d9d2f7 100644 --- a/modules/selenium/src/main/java/org/testcontainers/selenium/BrowserWebDriverContainer.java +++ b/modules/selenium/src/main/java/org/testcontainers/selenium/BrowserWebDriverContainer.java @@ -179,8 +179,7 @@ public URL getSeleniumAddress() { try { return new URL("http", getHost(), getMappedPort(SELENIUM_PORT), "/wd/hub"); } catch (MalformedURLException e) { - e.printStackTrace(); // TODO - return null; + throw new ContainerLaunchException("Could not construct Selenium address", e); } }