Skip to content

Commit 4c53b89

Browse files
fix(mssql): use ExecWaitStrategy instead of deprecated wait_container_is_ready (#1016)
## Related - #874 Signed-off-by: Edgar Ramírez Mondragón <edgarrm358@gmail.com>
1 parent d3a1517 commit 4c53b89

1 file changed

Lines changed: 8 additions & 5 deletions

File tree

modules/mssql/testcontainers/mssql/__init__.py

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
from testcontainers.core.generic import DbContainer
55
from testcontainers.core.utils import raise_for_deprecated_parameter
6-
from testcontainers.core.waiting_utils import wait_container_is_ready
6+
from testcontainers.core.wait_strategies import ExecWaitStrategy
77

88

99
class SqlServerContainer(DbContainer):
@@ -50,12 +50,15 @@ def _configure(self) -> None:
5050
self.with_env("SQLSERVER_DBNAME", self.dbname)
5151
self.with_env("ACCEPT_EULA", "Y")
5252

53-
@wait_container_is_ready(AssertionError)
5453
def _connect(self) -> None:
55-
status, _ = self.exec(
56-
["bash", "-c", '/opt/mssql-tools*/bin/sqlcmd -U "$SQLSERVER_USER" -P "$SA_PASSWORD" -Q \'SELECT 1\' -C']
54+
strategy = ExecWaitStrategy(
55+
[
56+
"bash",
57+
"-c",
58+
'/opt/mssql-tools*/bin/sqlcmd -U "$SQLSERVER_USER" -P "$SA_PASSWORD" -Q \'SELECT 1\' -C',
59+
]
5760
)
58-
assert status == 0, "Cannot run 'SELECT 1': container is not ready"
61+
strategy.wait_until_ready(self)
5962

6063
def get_connection_url(self) -> str:
6164
return super()._create_connection_url(

0 commit comments

Comments
 (0)