Changing one item in a list within a list?

[KVonGit]

I am porting the first table from the "FIGHTS" section: https://github.com/historicalsource/zork1/blob/97b7b3d68c075dd9af7da499c3e9690ada3471fd/1actions.zil#L3604-L3648

The table has seven "sub tables" (and each of those technically has its own table, but I'm using a string for that bit).

This script creates the list of lists perfectly fine, and I can properly navigate. The issue is the first item from each list...

Note that each "sub list" begins with "0". This is the CNT value for these in ZIL. That is used by the PICK-ONE routine. It's basically PickOneString, but it does not repeat any until it has shown them all. To do this, it increases the CNT value by one each time it runs on a table.

So, this game has a routine that chooses a table from the main table, then calls PICK-ONE on that. Then REMARK replaces F-DEF and/or F-WEP with the proper object alias.

I've got everything copied over to Quest. My issue is updating the CNT value in my list, so the change sticks in GLOBAL.HERO_MELEE.

GLOBAL.HERO_MELEE = NewList()
lst = NewStringList()
list add (lst, "0")
list add (lst, "Your F-WEP misses the F-DEF by an inch.")
list add (lst, "A good slash, but it misses the F-DEF by a mile.")
list add (lst, "You charge, but the F-DEF jumps nimbly aside.")
list add (lst, "Clang! Crash! The F-DEF parries.")
list add (lst, "A quick stroke, but the F-DEF is on guard.")
list add (lst, "A good stroke, but it's too slow; the F-DEF dodges.")
list add (GLOBAL.HERO_MELEE, lst)
lst = NewStringList()
list add (lst, "0")
list add (lst, "Your F-WEP crashes down, knocking the F-DEF into dreamland.")
list add (lst, "The F-DEF is battered into unconsciousness.")
list add (lst, "A furious exchange, and the F-DEF is knocked out!")
list add (lst, "The haft of your F-WEP knocks out the F-DEF.")
list add (lst, "The F-DEF is knocked out!")
list add (GLOBAL.HERO_MELEE, lst)
lst = NewStringList()
list add (lst, "0")
list add (lst, "It's curtains for the F-DEF as your F-WEP removes his head.")
list add (lst, "The fatal blow strikes the F-DEF square in the heart: He dies.")
list add (lst, "The F-DEF takes a fatal blow and slumps to the floor dead.")
list add (GLOBAL.HERO_MELEE, lst)
lst = NewStringList()
list add (lst, "0")
list add (lst, "The F-DEF is struck on the arm; blood begins to trickle down.")
list add (lst, "Your F-WEP pinks the F-DEF on the wrist, but it's not serious.")
list add (lst, "Your stroke lands, but it was only the flat of the blade.")
list add (lst, "The blow lands, making a shallow gash in the F-DEF's arm!")
list add (GLOBAL.HERO_MELEE, lst)
lst = NewStringList()
list add (lst, "0")
list add (lst, "The F-DEF receives a deep gash in his side.")
list add (lst, "A savage blow on the thigh! The F-DEF is stunned but can still fight!")
list add (lst, "Slash! Your blow lands! That one hit an artery, it could be serious!")
list add (lst, "Slash! Your stroke connects! This could be serious!")
list add (GLOBAL.HERO_MELEE, lst)
lst = NewStringList()
list add (lst, "0")
list add (lst, "The F-DEF is staggered, and drops to his knees.")
list add (lst, "The F-DEF is momentarily disoriented and can't fight back.")
list add (lst, "The force of your blow knocks the F-DEF back, stunned.")
list add (lst, "The F-DEF is confused and can't fight back.")
list add (lst, "The quickness of your thrust knocks the F-DEF back, stunned.")
list add (GLOBAL.HERO_MELEE, lst)
lst = NewStringList()
list add (lst, "0")
list add (lst, "The F-DEF's weapon is knocked to the floor, leaving him unarmed.")
list add (lst, "The F-DEF is disarmed by a subtle feint past his guard.")
list add (GLOBAL.HERO_MELEE, lst)

---

I think I'm going to have use separate list attributes, or maybe dictionaries, or something...

[KVonGit]

I can't figure out how to do it with lists, but I seem to have it working with dictionaries:

  <function name="PICK_ONE_PLUS" parameters="dict" type="string">
    FROB = DictionaryItem(dict, "lst")
    L = ListCount(FROB)
    CNT = DictionaryItem (dict, "cnt")
    L = L - 1
    RFROB = REST (FROB, CNT)
    // because RFROB is just a vanilla list after using REST
    lst = NewStringList()
    foreach(s,RFROB){
      list add(lst,s)
    }
    RFROB = lst
    FROB = ListExclude(FROB,RFROB)
    RND = RANDOM (L - CNT)
    MSG = StringListItem (RFROB, RND)
    RFROB = PUT (RFROB, RND, StringListItem (RFROB, 0))
    RFROB = PUT (RFROB, 0, MSG)
    // because RFROB is just a vanilla list after using PUT
    lst = NewStringList()
    foreach(s,FROB){
      list add(lst,s)
    }
    foreach(s,RFROB){
      list add(lst,s)
    }
    FROB = lst
    CNT = CNT + 1
    if (CNT = L + 1) {
      CNT = 0
    }
    dictionary remove (dict, "cnt")
    dictionary add (dict,"cnt",CNT)
    dictionary remove (dict,"lst")
    dictionary add (dict, "lst", FROB)
    return (MSG)
  </function>

---

Instead of the first element in the list being the CNT, the dictionary has separate "cnt" and "list" entries. Seemed like I might as well make that part slightly easier while I was already hacking it up.

[KVonGit]

[MANIACAL LAUGH]

I seem to have it working with a list within an object's list attribute (like the example in the first post in this thread). =)

   <function name="PICK_ONE" parameters="FROB" type="string"><![CDATA[
    L = ListCount(FROB) - 1
    CNT = ToInt(StringListItem(FROB,0))
    list remove (FROB, StringListItem(FROB,0))
    RFROB = NewStringList()
    tmplist = ListExclude(FROB,"")
    for (i, 0, L-1) {
      if (i >= CNT) {
        list remove (FROB, StringListItem(tmplist,i))
        list add (RFROB, StringListItem(tmplist,i))
      }
    }
    RND = RANDOM(L-CNT) - 1
    MSG = ListItem (RFROB, RND)
    tmplist = ListExclude(RFROB,"")
    RFROB = NewStringList()
    list add (RFROB, MSG)
    len = ListCount(tmplist)
    i = len - 1
    n = RND
    for (item, 0, i) {
      if (item = n) {
        list add (tmplist, ListItem(tmplist,0))
      }
      else {
        list add (RFROB, ListItem(tmplist,item))
      }
    }
    tmpfrob = ListExclude(FROB,"")
    CNT = CNT + 1
    if (CNT = L) {
      CNT = 0
    }
    foreach (s, tmpfrob) {
      list remove (FROB, s)
    }
    list add (FROB, ToString (CNT))
    foreach (s, tmpfrob) {
      list add (FROB, s)
    }
    foreach (s, RFROB) {
      list add (FROB, s)
    }
    return (MSG)
  ]]></function>

Test script:

msg ("=== MISS CATEGORY ===")
FROB = ListItem(GLOBAL.HERO_MELEE, 0)
REMARK(PICK_ONE(FROB),"thief","sword")
REMARK(PICK_ONE(FROB),"thief","sword")
REMARK(PICK_ONE(FROB),"thief","sword")
REMARK(PICK_ONE(FROB),"thief","sword")
REMARK(PICK_ONE(FROB),"thief","sword")
REMARK(PICK_ONE(FROB),"thief","sword")
msg ("cycled")
REMARK(PICK_ONE(FROB),"thief","sword")
msg ("=== HIT CATEGORY ===")
FROB = ListItem(GLOBAL.HERO_MELEE, 4)
REMARK(PICK_ONE(FROB),"thief","sword")
REMARK(PICK_ONE(FROB),"thief","sword")
REMARK(PICK_ONE(FROB),"thief","sword")
REMARK(PICK_ONE(FROB),"thief","sword")
msg ("cycled")
REMARK(PICK_ONE(FROB),"thief","sword")

Output:

=== MISS CATEGORY ===
A good stroke, but it's too slow; the thief dodges.
Clang! Crash! The thief parries.
A quick stroke, but the thief is on guard.
You charge, but the thief jumps nimbly aside.
A good slash, but it misses the thief by a mile.
Your sword misses the thief by an inch.
cycled
Your sword misses the thief by an inch.
=== HIT CATEGORY ===
Slash! Your stroke connects! This could be serious!
Slash! Your blow lands! That one hit an artery, it could be serious!
A savage blow on the thigh! The thief is stunned but can still fight!
The thief receives a deep gash in his side.
cycled
The thief receives a deep gash in his side.