From 284a166ab4081c3308e1d7741ef4426e77ef9fbb Mon Sep 17 00:00:00 2001 From: SyncIt21 <110812394+SyncIt21@users.noreply.github.com> Date: Thu, 4 Jun 2026 17:17:54 +0530 Subject: [PATCH 1/3] yup --- dist/index.js | 5 ++++- src/index.ts | 8 ++++---- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/dist/index.js b/dist/index.js index ccdf313..3354935 100644 --- a/dist/index.js +++ b/dist/index.js @@ -33216,7 +33216,10 @@ async function run() { trimmed_owners.push(owner.replace('@', '')); } //Remove PR author from the user list - trimmed_owners.splice(trimmed_owners.indexOf(response.data.user.login), 1); + const index = trimmed_owners.indexOf(response.data.user.login); + if (index >= 0) { + trimmed_owners.splice(index, 1); + } //No reviewers so stop here if (!trimmed_owners.length) { info('No reviewers to call'); diff --git a/src/index.ts b/src/index.ts index e933502..4b4ab24 100644 --- a/src/index.ts +++ b/src/index.ts @@ -156,10 +156,10 @@ async function run(): Promise { } //Remove PR author from the user list - trimmed_owners.splice( - trimmed_owners.indexOf(response.data.user.login), - 1 - ) + const index = trimmed_owners.indexOf(response.data.user.login) + if (index >= 0) { + trimmed_owners.splice(index, 1) + } //No reviewers so stop here if (!trimmed_owners.length) { From b35d95ab858ee6a109d78ef2bae27b4b71ca774f Mon Sep 17 00:00:00 2001 From: SyncIt21 <110812394+SyncIt21@users.noreply.github.com> Date: Thu, 4 Jun 2026 21:22:01 +0530 Subject: [PATCH 2/3] sleep reviewers for draft PR's --- dist/index.js | 9 +++++++++ src/index.ts | 11 +++++++++++ 2 files changed, 20 insertions(+) diff --git a/dist/index.js b/dist/index.js index 3354935..7506270 100644 --- a/dist/index.js +++ b/dist/index.js @@ -33193,6 +33193,15 @@ async function run() { repo: core_repo, pull_number: pull_number }); + //For draft Pr's put any requested reviewers to sleep + if (response.data.draft) { + await octokit.rest.pulls.requestReviewers({ + owner: core_owner, + repo: core_repo, + pull_number: pull_number + }); + return; + } if (response.data.changed_files > FILE_LIMIT) { setFailed(`PR has ${response.data.changed_files} files, which is more than the limit of ${FILE_LIMIT}. Skipping codeowner assignment.`); return; diff --git a/src/index.ts b/src/index.ts index 4b4ab24..649e348 100644 --- a/src/index.ts +++ b/src/index.ts @@ -115,6 +115,17 @@ async function run(): Promise { pull_number: pull_number }) + //For draft Pr's put any requested reviewers to sleep + if (response.data.draft) { + await octokit.rest.pulls.requestReviewers({ + owner: core_owner, + repo: core_repo, + pull_number: pull_number + }) + + return + } + if (response.data.changed_files > FILE_LIMIT) { setFailed( `PR has ${response.data.changed_files} files, which is more than the limit of ${FILE_LIMIT}. Skipping codeowner assignment.` From 89962f88c46f762494352b7c632197bf706597a7 Mon Sep 17 00:00:00 2001 From: SyncIt21 <110812394+SyncIt21@users.noreply.github.com> Date: Thu, 4 Jun 2026 22:01:12 +0530 Subject: [PATCH 3/3] put everything back --- dist/index.js | 11 +---------- src/index.ts | 13 +------------ 2 files changed, 2 insertions(+), 22 deletions(-) diff --git a/dist/index.js b/dist/index.js index 7506270..d4a29b2 100644 --- a/dist/index.js +++ b/dist/index.js @@ -33193,15 +33193,6 @@ async function run() { repo: core_repo, pull_number: pull_number }); - //For draft Pr's put any requested reviewers to sleep - if (response.data.draft) { - await octokit.rest.pulls.requestReviewers({ - owner: core_owner, - repo: core_repo, - pull_number: pull_number - }); - return; - } if (response.data.changed_files > FILE_LIMIT) { setFailed(`PR has ${response.data.changed_files} files, which is more than the limit of ${FILE_LIMIT}. Skipping codeowner assignment.`); return; @@ -33219,8 +33210,8 @@ async function run() { // Display all code owners info(`Owners With Modified Files: ${ownersWithModifiedFiles.join(' ')}`); //# Part 2: Requesting reviews based on owners listed above - //Remove the @ symbol at the start of every owner name const trimmed_owners = []; + //Remove the @ symbol at the start of every owner name for (const owner of ownersWithModifiedFiles) { trimmed_owners.push(owner.replace('@', '')); } diff --git a/src/index.ts b/src/index.ts index 649e348..f2401f0 100644 --- a/src/index.ts +++ b/src/index.ts @@ -115,17 +115,6 @@ async function run(): Promise { pull_number: pull_number }) - //For draft Pr's put any requested reviewers to sleep - if (response.data.draft) { - await octokit.rest.pulls.requestReviewers({ - owner: core_owner, - repo: core_repo, - pull_number: pull_number - }) - - return - } - if (response.data.changed_files > FILE_LIMIT) { setFailed( `PR has ${response.data.changed_files} files, which is more than the limit of ${FILE_LIMIT}. Skipping codeowner assignment.` @@ -159,9 +148,9 @@ async function run(): Promise { info(`Owners With Modified Files: ${ownersWithModifiedFiles.join(' ')}`) //# Part 2: Requesting reviews based on owners listed above + const trimmed_owners: string[] = [] //Remove the @ symbol at the start of every owner name - const trimmed_owners: string[] = [] for (const owner of ownersWithModifiedFiles) { trimmed_owners.push(owner.replace('@', '')) }