ArgumentException: invalid utf-16 sequence at 16376912 (missing surrogate tail)

[originalfoo]

Looks like there's a broken vehicle asset in workshop, and when LSM tries to report that it's broken it fails with this exception (ignore the +/- signs, just using them to highlight parts of the stack trace):

- ArgumentException: invalid utf-16 sequence at 16376912 (missing surrogate tail)
Parameter name: string
  at (wrapper managed-to-native) UnityEngine.UnityLogWriter:WriteStringToUnityLog (string)
  at UnityEngine.UnityLogWriter.Write (System.String s) [0x00000] in <filename unknown>:0 
  at System.IO.TextWriter.WriteLine (System.String value) [0x00000] in <filename unknown>:0 
  at System.Console.WriteLine (System.String value) [0x00000] in <filename unknown>:0 
  at LoadingScreenMod.Util.DebugPrint (System.Object[] args) [0x00000] in <filename unknown>:0 
  at LoadingScreenMod.AssetLoader.NotFound (System.String fullName) [0x00000] in <filename unknown>:0 
  at LoadingScreenMod.UsedAssets.ReportMissingAssets[VehicleInfo] (System.Collections.Generic.HashSet`1 customAssets, Type type) [0x00000] in <filename unknown>:0 
UnityEngine.DebugLogHandler:Internal_LogException(Exception, Object)
UnityEngine.DebugLogHandler:LogException(Exception, Object)
UnityEngine.Logger:LogException(Exception, Object)
UnityEngine.Debug:LogException(Exception)
+ LoadingScreenMod.UsedAssets:ReportMissingAssets(HashSet`1, Type)
LoadingScreenMod.UsedAssets:ReportMissingAssets()
LoadingScreenMod.AssetLoader:Report()
LoadingScreenMod.<LoadCustomContent>d__27:MoveNext()
LoadingManager:Update()
 
(Filename:  Line: -1)

The result is that when user enters game, they see something like this:

Windows - utf-16 Surrogate Tail.txt

User was playing a savegame from workshop, I've asked for a link which may hopefully track down the problem (I assume....) vehicle asset.

[originalfoo]

City being loaded was from workshop: Bee City.

List of workshop assets, trimmed from log file (I've highlighted some known-good assets in green with + sign; those can likely be ignored):

\418796812\Bus Station+Metro in Roundabout.crp
\493654141\Pedestrian Overpass - Any Large .crp
\528264187\3 way interchange #2.crp
\413566741\4-Way Pinavia Interchange U.crp
+ \406269372\Timboh's Turbine Interchange.crp
+ \411393372\Timboh's B-Trumpet Interchange.crp
+ \412785623\Timboh's Y-Stack Interchange.crp
+ \410030389\Timboh's A-4 Parclo Interchange.crp
+ \409503100\Timboh's Roundabout Interchange.crp
+ \410030736\Timboh's A-Trumpet Interchange.crp
\1659949188\parclo_dogbone.crp
\529294835\REAL supermarket.crp
\456191401\411PlatformMetro.crp
\452708804\4PlatformMetro.crp
\454379736\4+PlatformMetro.crp
\573198132\Modular Bus Station.crp
\868718614\Nonstop Bus Terminal.crp
\1592166483\NTE - Falcon Bus Station.crp
\1866898625\Parking Lot 2x6 [functional].crp
\1866898351\Parking Lot 2x2 [functional].crp
\1866898495\Parking Lot 2x4 [functional].crp
\1870164676\Lane-split roundabout + overpass.crp
\1868590554\Highway End Avenue + Roundabouts.crp
+ \406288933\Timboh's Duo Trumpet Interchange.crp
+ \408338500\Timboh's Pentagon Interchange.crp
+ \406646871\Timboh's Windmill Interchange.crp
+ \406647772\Timboh's Clovermill Interchange.crp
\504193884\Medium Parking Garage.crp
+ \407933040\Timboh's Stack Interchange.crp
\1805853225\Tennis Clubhouse.crp
\1758415471\sFireStationNo1.crp
+ \1877941422\Police Station (Medium).crp
\1516939108\roundabout-smallhighway.crp
\1535630437\QuickSave20171019230358756.crp
\1722143348\Toon.crp
\1746360304\Carmen Belay - Fix My City!.crp
\1698971152\LALALALALALAA.crp
\1771989505\Fixing Saving.crp
\1858177731\My city is Epic.crp
- \1898678484\Bee City .crp
\1801867119\Whyistrafficsobad.crp
\1912109140\NewSaveFixed.crp
\1885358349\FORBIFFATOFIX.crp
\1861376035\City 17 Fix.crp
\1706690168\Biffa.crp
\1711704525\Biffa CIty to fix - Improved.crp
- \1402899089\Actuell %003A) .crp
\1762968680\Grid locked.crp
\1723475760\fix my traffic.crp
\1960733102\Coconut Bay (CityFix).crp
\409235368\Working City.crp
\443433253\Riverfield.crp
\1956391981\Jack City.crp
\1960751458\GuuderTown.crp
\1709926709\urban devlopment.crp

This looks odd:

\1402899089\Actuell %003A) .crp

[originalfoo]

All the info above from a user (Diabolic_khaos) on /r/CitiesSkylines discord server.

But I also noticed few days ago another user on the Paradox support fprums with same error - there are additional log files and details in this topic: https://forum.paradoxplaza.com/forum/index.php?threads/cities-skylines-steam-invalid-utf-16-sequence-missing-surrogate-tail-parameter-s.1328489/

[originalfoo]

Savegame that exhibits the error: https://forum.paradoxplaza.com/forum/index.php?threads/cities-skylines-steam-invalid-utf-16-sequence-missing-surrogate-tail-parameter-s.1328489/#post-26299564

[thale5]

Thanks, I'll take a look at that save.

The stack trace is quite clear. The issue is a custom vehicle with an invalid name. The vehicle is missing but its name is recorded in the save and is reported as missing. The ArgumentException is caught in my try-catch handler in ReportMissingAssets. That stack trace is printed by my catch block. All that seems fine.

Now I'm wondering if the exception is actually re-thrown in the catch block (which would be bad) because the very toxic asset name is included in the stack trace message?

[thale5]

It is also possible (and even likely) that the exception is handled like it should and there is no problem with that. The fact that the city does not load may be another, unrelated issue with the savegame.

[thale5]

That savegame (NewSave.crp) is unrelated. Maybe the user uploaded the wrong file by mistake.