module_adapter: avoid module init crash in case of ipc data invalid

btian1 · btian1 · commit 7600323a2cdb · 2023-08-04T09:54:31.000+08:00
In ipc3 module creation, it is possible that ipc data
is invalid or corrupted, in this case, module init may crash.
This patch is adding error handling to avoid crash.

Signed-off-by: Baofeng Tian &lt;baofeng.tian@intel.com&gt;
diff --git a/src/audio/module_adapter/module_adapter.c b/src/audio/module_adapter/module_adapter.c
@@ -130,6 +130,8 @@ struct comp_dev *module_adapter_new(const struct comp_driver *drv,
 			goto err;
 		}
 		dst->init_data = dst->data;
+	} else {
+		goto err;
 	}
 #else
 	if (drv->type == SOF_COMP_MODULE_ADAPTER) {

Original file line number	Diff line number	Diff line change
`@@ -130,6 +130,8 @@ struct comp_dev module_adapter_new(const struct comp_driver drv,`
`130`	`130`	`goto err;`
`131`	`131`	`}`
`132`	`132`	`dst->init_data = dst->data;`
	`133`	`+ } else {`
	`134`	`+ goto err;`
`133`	`135`	`}`
`134`	`136`	`#else`
`135`	`137`	`if (drv->type == SOF_COMP_MODULE_ADAPTER) {`