ipc: Fix typo in error checking

andyross · andyross · commit e52e7723d532 · 2023-07-06T10:46:30.000-07:00
Found a oss-fuzz error I thought I'd fixed being reported again.
Turns out the fix had a typo and only fixed half the problem space.
Need to check source and sink, not source and source!

Signed-off-by: Andy Ross &lt;andyross@google.com&gt;
diff --git a/src/ipc/ipc-helper.c b/src/ipc/ipc-helper.c
@@ -291,7 +291,7 @@ int ipc_comp_free(struct ipc *ipc, uint32_t comp_id)
 		return -EINVAL;
 	}
 
-	if (!icd->cd->bsource_list.next || !icd->cd->bsource_list.next) {
+	if (!icd->cd->bsource_list.next || !icd->cd->bsink_list.next) {
 		/* Unfortunate: the buffer list node gets initialized
 		 * at the component level and thus can contain NULLs
 		 * (which is an invalid list!) if the component's

Original file line number	Diff line number	Diff line change
`@@ -291,7 +291,7 @@ int ipc_comp_free(struct ipc *ipc, uint32_t comp_id)`
`291`	`291`	`return -EINVAL;`
`292`	`292`	`}`
`293`	`293`
`294`		`- if (!icd->cd->bsource_list.next \|\| !icd->cd->bsource_list.next) {`
	`294`	`+ if (!icd->cd->bsource_list.next \|\| !icd->cd->bsink_list.next) {`
`295`	`295`	`/* Unfortunate: the buffer list node gets initialized`
`296`	`296`	`* at the component level and thus can contain NULLs`
`297`	`297`	`* (which is an invalid list!) if the component's`