Skip to content

TUI bulk-edit: custom-field edits silently don't save (include toggle invisible) + raw custom_fields.<name> labels #137

Description

@thomaschristory

Symptoms

When bulk-editing in the TUI, custom fields show an ugly custom_fields.<name> name and edits made there don't save (silent — no change, no error).

Root causes

  1. Invisible include toggle (the save bug). .bulk-include { width: 6 } is too narrow for a Textual Switch (border + padding + slider ≈ 10 cells); with the real stylesheet the slider clips to zero width, so every per-field include toggle renders blank. Users can't see or flip it, so no field is opted in and the patch is empty → silent no-change.
  2. Raw custom-field labels. Both the single-edit and bulk-edit forms render Label(name) (the raw custom_fields.<name> key) instead of the fetched CustomFieldDef.label. Same in the change-preview diff.
  3. Latent: opting in a blank select nulls the field. A select whose choice-set didn't resolve renders empty; opting it in seeded None and silently cleared a value the user never edited.

Fixes

  • Size .bulk-include to fit the Switch slider (regression-tested so it can't clip to zero again).
  • Render spec.label or name in both forms and thread custom-field labels into the diff rows.
  • A blank select seeds nothing on opt-in; only the explicit ∅ button nulls.

Reported by maintainer.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions