Fix Julia 1.11 compatibility#41
Open
andreasnoack wants to merge 1 commit into
Open
Conversation
- Handle different SimpleVector layout between Julia 1.11 (8 elements with ext_targets) and 1.12 (7 elements without) when completeinfo=true - Guard Core.GlobalMethods usage with isdefined check since it only exists in Julia 1.12+ - Only use ocache (.dylib) path for pkgimage packages by checking clone_targets, avoiding CRC errors on non-pkgimage caches - Restore compat to julia = "1.11" and add 1.11 to CI matrix Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SimpleVectorlayout between Julia 1.11 (8 elements withext_targets) and 1.12 (7 elements without) returned byjl_restore_incremental/jl_restore_package_image_from_filewithcompleteinfo=trueCore.GlobalMethodsusage incount_internal_methodswith@static if isdefined(Core, :GlobalMethods)since it only exists in Julia 1.12+.dylib) path for pkgimage packages by checking!isempty(clone_targets), avoiding attempts to load non-existent.dylibfiles for non-pkgimage cachesjulia = "1.11"and add'min'(1.11) to the CI test matrixTest plan
info_cachefile("Pumas")works on Julia 1.11.9 (large pkgimage package with 524 dependencies)info_cachefile("Colors")works on Julia 1.11.9🤖 Generated with Claude Code