fix error in the API params to create a branch

Author: manumartinm

src/tinybird_sdk/api/branches.py

@@ -5,12 +5,9 @@
 from typing import Any
 from urllib.parse import urlencode
 
+from ..cli.config_types import BranchDataMode
 from .fetcher import tinybird_fetch
 
-LAST_PARTITION = "last_partition"
-
-LAST_PARTITION = "last_partition"
-
 
 @dataclass(frozen=True, slots=True)
 class BranchApiConfig:
@@ -28,7 +25,7 @@ class TinybirdBranch:
 
 @dataclass(frozen=True, slots=True)
 class CreateBranchOptions:
-    last_partition: bool = False
+    branch_data_mode: BranchDataMode | None = None
 
 
 class BranchApiError(Exception):
@@ -79,8 +76,8 @@ def create_branch(
 ) -> TinybirdBranch:
     normalized = config if isinstance(config, BranchApiConfig) else BranchApiConfig(**config)
     params = {"name": name}
-    if options and options.last_partition:
-        params["data"] = LAST_PARTITION
+    if options and options.branch_data_mode:
+        params["data"] = options.branch_data_mode
     url = f"{normalized.base_url.rstrip('/')}/v1/environments?{urlencode(params)}"
     response = tinybird_fetch(url, method="POST", headers=_headers(normalized.token))
 

src/tinybird_sdk/cli/commands/build.py

@@ -141,9 +141,7 @@ def run_build(options: BuildCommandOptions | dict[str, Any] | None = None) -> Bu
                 branch_options = None
                 branch_value = config.get("branch_data_mode")
                 if branch_value and config.get("dev_mode") != "local":
-                    branch_options = CreateBranchOptions(
-                        last_partition=(branch_value == "last_partition"),
-                    )
+                    branch_options = CreateBranchOptions(branch_data_mode=branch_value)
                 branch = get_or_create_branch(
                     {"base_url": config["base_url"], "token": config["token"]},
                     config["tinybird_branch"],

src/tinybird_sdk/cli/commands/clear.py

@@ -63,7 +63,7 @@ def run_clear(options: ClearCommandOptions | dict[str, Any] | None = None) -> Cl
         branch_options = None
         branch_value = config.get("branch_data_mode")
         if branch_value and config.get("dev_mode") != "local":
-            branch_options = CreateBranchOptions(last_partition=(branch_value == "last_partition"))
+            branch_options = CreateBranchOptions(branch_data_mode=branch_value)
 
         clear_branch(
             {"base_url": config["base_url"], "token": config["token"]},

src/tinybird_sdk/cli/commands/preview.py

@@ -154,9 +154,7 @@ def run_preview(
         branch_options = None
         branch_value = config.get("branch_data_mode")
         if branch_value and config.get("dev_mode") != "local":
-            branch_options = CreateBranchOptions(
-                last_partition=(branch_value == "last_partition"),
-            )
+            branch_options = CreateBranchOptions(branch_data_mode=branch_value)
         branch = create_branch(
             {"base_url": config["base_url"], "token": config["token"]},
             preview_branch_name,

src/tinybird_sdk/client/base.py

@@ -162,9 +162,7 @@ def _resolve_branch_context(self) -> ClientContext:
             branch_options = None
             branch_value = config.get("branch_data_mode")
             if branch_value and config.get("dev_mode") != "local":
-                branch_options = CreateBranchOptions(
-                    last_partition=(branch_value == "last_partition")
-                )
+                branch_options = CreateBranchOptions(branch_data_mode=branch_value)
 
             branch = get_or_create_branch(
                 {

tests/test_api_branches_options.py

@@ -40,7 +40,7 @@ def fake_fetch(url: str, **_kwargs: Any) -> _FakeResponse:
     create_branch(
         {"base_url": "https://api.tinybird.co", "token": "p.test"},
         "x",
-        options=CreateBranchOptions(last_partition=True),
+        options=CreateBranchOptions(branch_data_mode="last_partition"),
     )
 
     parsed = urlparse(called_urls[0])
@@ -89,9 +89,9 @@ def fake_create_branch(
     clear_branch(
         {"base_url": "https://api.tinybird.co", "token": "p.test"},
         "x",
-        options=CreateBranchOptions(last_partition=True),
+        options=CreateBranchOptions(branch_data_mode="last_partition"),
     )
 
     assert len(captured_options) == 1
     assert captured_options[0] is not None
-    assert captured_options[0].last_partition is True
+    assert captured_options[0].branch_data_mode == "last_partition"

tests/test_client_parity.py

@@ -76,7 +76,7 @@ def fake_get_or_create_branch(*_args: Any, **kwargs: Any) -> dict[str, Any]:
     assert context["token"] == "branch_token"
     assert context["is_branch_token"] is True
     assert context["branch_name"] == "feature_alpha"
-    assert captured["options"].last_partition is True
+    assert captured["options"].branch_data_mode == "last_partition"
 
 
 def test_tokens_namespace_wraps_token_api_errors(monkeypatch: pytest.MonkeyPatch) -> None: