Skip to content

Add proper exception handling on unexpected outage #1

@MarinaRybalko

Description

@MarinaRybalko

Thanks for the great library!
It has a lot of useful functionality. It will be perfect to add proper exception handling on unexpected outage.

TransmitSMS has had unexpected outage recently.
When we tried to send sms during outage we got following error message.

Failed to parse the response: Unexpected character encountered while parsing value: <. Path '', line 0, position 0.

That exception was thrown in https://github.com/transmitsms/transmitsms-api-csharp-client/blob/master/TransmitSMS.Standard/Controllers/SMSController.cs#L185

From the exception message it is not obvious why error occurred. May be it is issue on our side and we missed something in configuration or sms that we are trying to send has unsupported content (special character, too long).

Could you please add exception handling for unexpected outage cases?
It will be helpful not to have just Failed to parse the response: message, but something like Unexpected outage. We are currently working on resolving issue.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions